Source code
Revision control
Copy as Markdown
Other Tools
# mypy: allow-untyped-defs
import os
from unittest import mock
from ..lint import check_path, check_unique_case_insensitive_paths
from .base import check_errors
import pytest
def test_allowed_path_length():
basename = 29 * "test/"
for idx in range(5):
filename = basename + idx * "a"
errors = check_path("/foo/", filename)
check_errors(errors)
assert errors == []
def test_forbidden_path_length():
basename = 29 * "test/"
for idx in range(5, 10):
filename = basename + idx * "a"
message = f"/{filename} longer than maximum path length ({146 + idx} > 150)"
errors = check_path("/foo/", filename)
check_errors(errors)
assert errors == [("PATH LENGTH", message, filename, None)]
@pytest.mark.parametrize("path_ending,generated", [(".worker.html", ".worker.js"),
(".any.worker.html", ".any.js"),
(".any.html", ".any.js")])
def test_forbidden_path_endings(path_ending, generated):
path = "test/test" + path_ending
message = ("path ends with %s which collides with generated tests from %s files" %
(path_ending, generated))
errors = check_path("/foo/", path)
check_errors(errors)
assert errors == [("WORKER COLLISION", message, path, None)]
def test_file_type():
path = "test/test"
message = f"/{path} is an unsupported file type (symlink)"
with mock.patch("os.path.islink", returnvalue=True):
errors = check_path("/foo/", path)
assert errors == [("FILE TYPE", message, path, None)]
@pytest.mark.parametrize("path", ["ahem.ttf",
"Ahem.ttf",
"ahem.tTf",
"not-ahem.ttf",
"support/ahem.ttf",
"ahem/other.ttf"])
def test_ahem_copy(path):
expected_error = ("AHEM COPY",
"Don't add extra copies of Ahem, use /fonts/Ahem.ttf",
path,
None)
errors = check_path("/foo/", path)
assert errors == [expected_error]
@pytest.mark.parametrize("path", ["ahem.woff",
"ahem.ttff",
"support/ahem.woff",
"ahem/other.woff"])
def test_ahem_copy_negative(path):
errors = check_path("/foo/", path)
assert errors == []
def test_mojom_js_file():
path = "resources/fake_device.mojom.js"
errors = check_path("/foo/", path)
assert errors == [("MOJOM-JS",
"Don't check *.mojom.js files into WPT",
path,
None)]
@pytest.mark.parametrize("path", ["css/foo.tentative/bar.html",
"css/.tentative/bar.html",
"css/tentative.bar/baz.html",
"css/bar-tentative/baz.html"])
def test_tentative_directories(path):
path = os.path.join(*path.split("/"))
expected_error = ("TENTATIVE-DIRECTORY-NAME",
"Directories for tentative tests must be named exactly 'tentative'",
path,
None)
errors = check_path("/foo/", path)
assert errors == [expected_error]
@pytest.mark.parametrize("path", ["css/bar.html",
"css/tentative/baz.html"])
def test_tentative_directories_negative(path):
path = os.path.join(*path.split("/"))
errors = check_path("/foo/", path)
assert errors == []
@pytest.mark.parametrize("path", ["elsewhere/.gitignore",
"else/where/.gitignore"
"elsewhere/tools/.gitignore",
"elsewhere/docs/.gitignore",
"elsewhere/resources/webidl2/.gitignore"])
def test_gitignore_file(path):
path = os.path.join(*path.split("/"))
expected_error = ("GITIGNORE",
".gitignore found outside the root",
path,
None)
errors = check_path("/foo/", path)
assert errors == [expected_error]
@pytest.mark.parametrize("path", [".gitignore",
"elsewhere/.gitignores",
"elsewhere/name.gitignore",
"tools/.gitignore",
"tools/elsewhere/.gitignore",
"docs/.gitignore"
"docs/elsewhere/.gitignore",
"resources/webidl2/.gitignore",
"resources/webidl2/elsewhere/.gitignore"])
def test_gitignore_negative(path):
path = os.path.join(*path.split("/"))
errors = check_path("/foo/", path)
assert errors == []
@pytest.mark.parametrize("paths,errors",
[(["a/b.html", "a/B.html"], ["a/B.html"]),
(["A/b.html", "a/b.html"], ["a/b.html"]),
(["a/b.html", "a/c.html"], [])])
def test_unique_case_insensitive_paths(paths, errors):
got_errors = check_unique_case_insensitive_paths(None, paths)
assert len(got_errors) == len(errors)
for (name, _, path, _), expected_path in zip(got_errors, errors):
assert name == "DUPLICATE-CASE-INSENSITIVE-PATH"
assert path == expected_path