Source code
Revision control
Copy as Markdown
Other Tools
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*-
* vim: set ts=8 sts=2 et sw=2 tw=80:
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
#include "vm/Shape-inl.h"
#include "mozilla/MathAlgorithms.h"
#include "gc/HashUtil.h"
#include "js/friend/WindowProxy.h" // js::IsWindow
#include "js/HashTable.h"
#include "js/Printer.h" // js::GenericPrinter, js::Fprinter
#include "js/UniquePtr.h"
#include "vm/JSObject.h"
#include "vm/JSONPrinter.h" // js::JSONPrinter
#include "vm/ShapeZone.h"
#include "vm/Watchtower.h"
#include "gc/StableCellHasher-inl.h"
#include "vm/JSContext-inl.h"
#include "vm/JSObject-inl.h"
#include "vm/NativeObject-inl.h"
using namespace js;
/* static */
bool Shape::replaceShape(JSContext* cx, HandleObject obj,
ObjectFlags objectFlags, TaggedProto proto,
uint32_t nfixed) {
Shape* newShape;
switch (obj->shape()->kind()) {
case Kind::Shared: {
Handle<NativeObject*> nobj = obj.as<NativeObject>();
if (nobj->shape()->propMap()) {
Rooted<BaseShape*> base(cx, obj->shape()->base());
if (proto != base->proto()) {
Rooted<TaggedProto> protoRoot(cx, proto);
base = BaseShape::get(cx, base->clasp(), base->realm(), protoRoot);
if (!base) {
return false;
}
}
Rooted<SharedPropMap*> map(cx, nobj->sharedShape()->propMap());
uint32_t mapLength = nobj->shape()->propMapLength();
newShape = SharedShape::getPropMapShape(cx, base, nfixed, map,
mapLength, objectFlags);
} else {
newShape = SharedShape::getInitialShape(
cx, obj->shape()->getObjectClass(), obj->shape()->realm(), proto,
nfixed, objectFlags);
}
break;
}
case Kind::Dictionary: {
Handle<NativeObject*> nobj = obj.as<NativeObject>();
Rooted<BaseShape*> base(cx, nobj->shape()->base());
if (proto != base->proto()) {
Rooted<TaggedProto> protoRoot(cx, proto);
base = BaseShape::get(cx, nobj->getClass(), nobj->realm(), protoRoot);
if (!base) {
return false;
}
}
Rooted<DictionaryPropMap*> map(cx, nobj->dictionaryShape()->propMap());
uint32_t mapLength = nobj->shape()->propMapLength();
newShape =
DictionaryShape::new_(cx, base, objectFlags, nfixed, map, mapLength);
break;
}
case Kind::Proxy:
MOZ_ASSERT(nfixed == 0);
newShape =
ProxyShape::getShape(cx, obj->shape()->getObjectClass(),
obj->shape()->realm(), proto, objectFlags);
break;
case Kind::WasmGC:
MOZ_ASSERT(nfixed == 0);
const wasm::RecGroup* recGroup = obj->shape()->asWasmGC().recGroup();
newShape = WasmGCShape::getShape(cx, obj->shape()->getObjectClass(),
obj->shape()->realm(), proto, recGroup,
objectFlags);
break;
}
if (!newShape) {
return false;
}
obj->setShape(newShape);
return true;
}
/* static */
bool js::NativeObject::toDictionaryMode(JSContext* cx,
Handle<NativeObject*> obj) {
MOZ_ASSERT(!obj->inDictionaryMode());
MOZ_ASSERT(cx->isInsideCurrentCompartment(obj));
RootedTuple<NativeShape*, SharedPropMap*, DictionaryPropMap*, BaseShape*>
roots(cx);
RootedField<NativeShape*> shape(roots, obj->shape());
uint32_t span = obj->slotSpan();
uint32_t mapLength = shape->propMapLength();
MOZ_ASSERT(mapLength > 0, "shouldn't convert empty object to dictionary");
// Clone the shared property map to an unshared dictionary map.
RootedField<SharedPropMap*> map(roots, shape->propMap()->asShared());
RootedField<DictionaryPropMap*> dictMap(
roots, SharedPropMap::toDictionaryMap(cx, map, mapLength));
if (!dictMap) {
return false;
}
// Allocate and use a new dictionary shape.
RootedField<BaseShape*> base(roots, shape->base());
shape = DictionaryShape::new_(cx, base, shape->objectFlags(),
shape->numFixedSlots(), dictMap, mapLength);
if (!shape) {
return false;
}
obj->setShape(shape);
MOZ_ASSERT(obj->inDictionaryMode());
obj->setDictionaryModeSlotSpan(span);
return true;
}
namespace js {
class MOZ_RAII AutoCheckShapeConsistency {
#ifdef DEBUG
Handle<NativeObject*> obj_;
#endif
public:
explicit AutoCheckShapeConsistency(Handle<NativeObject*> obj)
#ifdef DEBUG
: obj_(obj)
#endif
{
}
#ifdef DEBUG
~AutoCheckShapeConsistency() { obj_->checkShapeConsistency(); }
#endif
};
} // namespace js
/* static */ MOZ_ALWAYS_INLINE bool
NativeObject::maybeConvertToDictionaryForAdd(JSContext* cx,
Handle<NativeObject*> obj) {
if (obj->inDictionaryMode()) {
return true;
}
SharedPropMap* map = obj->sharedShape()->propMap();
if (!map) {
return true;
}
if (MOZ_LIKELY(!map->shouldConvertToDictionaryForAdd())) {
return true;
}
return toDictionaryMode(cx, obj);
}
static void AssertValidCustomDataProp(NativeObject* obj, PropertyFlags flags) {
// We only support custom data properties on ArrayObject and ArgumentsObject.
// The mechanism is deprecated so we don't want to add new uses.
MOZ_ASSERT(flags.isCustomDataProperty());
MOZ_ASSERT(!flags.isAccessorProperty());
MOZ_ASSERT(obj->is<ArrayObject>() || obj->is<ArgumentsObject>());
}
/* static */
bool NativeObject::addCustomDataProperty(JSContext* cx,
Handle<NativeObject*> obj, HandleId id,
PropertyFlags flags) {
MOZ_ASSERT(!id.isVoid());
MOZ_ASSERT(!id.isPrivateName());
MOZ_ASSERT(!obj->containsPure(id));
AutoCheckShapeConsistency check(obj);
AssertValidCustomDataProp(obj, flags);
if (!Watchtower::watchPropertyAdd(cx, obj, id)) {
return false;
}
if (!maybeConvertToDictionaryForAdd(cx, obj)) {
return false;
}
ObjectFlags objectFlags = obj->shape()->objectFlags();
const JSClass* clasp = obj->shape()->getObjectClass();
if (obj->inDictionaryMode()) {
// First generate a new dictionary shape so that the map can be mutated
// without having to worry about OOM conditions.
if (!NativeObject::generateNewDictionaryShape(cx, obj)) {
return false;
}
Rooted<DictionaryPropMap*> map(cx, obj->dictionaryShape()->propMap());
uint32_t mapLength = obj->shape()->propMapLength();
if (!DictionaryPropMap::addProperty(cx, clasp, &map, &mapLength, id, flags,
SHAPE_INVALID_SLOT, &objectFlags)) {
return false;
}
obj->dictionaryShape()->updateNewShape(objectFlags, map, mapLength);
return true;
}
Rooted<SharedPropMap*> map(cx, obj->sharedShape()->propMap());
uint32_t mapLength = obj->shape()->propMapLength();
if (!SharedPropMap::addCustomDataProperty(cx, clasp, &map, &mapLength, id,
flags, &objectFlags)) {
return false;
}
Shape* shape = SharedShape::getPropMapShape(cx, obj->shape()->base(),
obj->shape()->numFixedSlots(),
map, mapLength, objectFlags);
if (!shape) {
return false;
}
obj->setShape(shape);
return true;
}
static ShapeSetForAdd* MakeShapeSetForAdd(SharedShape* shape1,
SharedShape* shape2) {
MOZ_ASSERT(shape1 != shape2);
MOZ_ASSERT(shape1->propMapLength() == shape2->propMapLength());
auto hash = MakeUnique<ShapeSetForAdd>();
if (!hash || !hash->reserve(2)) {
return nullptr;
}
PropertyInfoWithKey prop = shape1->lastProperty();
hash->putNewInfallible(ShapeForAddHasher::Lookup(prop.key(), prop.flags()),
shape1);
prop = shape2->lastProperty();
hash->putNewInfallible(ShapeForAddHasher::Lookup(prop.key(), prop.flags()),
shape2);
return hash.release();
}
static MOZ_ALWAYS_INLINE SharedShape* LookupShapeForAdd(Shape* shape,
PropertyKey key,
PropertyFlags flags,
uint32_t* slot) {
ShapeCachePtr cache = shape->cache();
if (cache.isSingleShapeForAdd()) {
SharedShape* newShape = cache.toSingleShapeForAdd();
if (newShape->lastPropertyMatchesForAdd(key, flags, slot)) {
return newShape;
}
return nullptr;
}
if (cache.isShapeSetForAdd()) {
ShapeSetForAdd* set = cache.toShapeSetForAdd();
ShapeForAddHasher::Lookup lookup(key, flags);
if (auto p = set->lookup(lookup)) {
SharedShape* newShape = *p;
*slot = newShape->lastProperty().slot();
return newShape;
}
return nullptr;
}
MOZ_ASSERT(!cache.isForAdd());
return nullptr;
}
// Add shapes with a non-None ShapeCachePtr to the shapesWithCache list so that
// these caches can be discarded on GC.
static bool RegisterShapeCache(JSContext* cx, Shape* shape) {
ShapeCachePtr cache = shape->cache();
if (!cache.isNone()) {
// Already registered this shape.
return true;
}
return cx->zone()->shapeZone().shapesWithCache.append(shape);
}
/* static */
bool NativeObject::addProperty(JSContext* cx, Handle<NativeObject*> obj,
HandleId id, PropertyFlags flags,
uint32_t* slot) {
AutoCheckShapeConsistency check(obj);
MOZ_ASSERT(!flags.isCustomDataProperty(),
"Use addCustomDataProperty for custom data properties");
// The object must not contain a property named |id|. The object must be
// extensible, but allow private fields and sparsifying dense elements.
MOZ_ASSERT(!id.isVoid());
MOZ_ASSERT(!obj->containsPure(id));
MOZ_ASSERT_IF(!id.isPrivateName(),
obj->isExtensible() ||
(id.isInt() && obj->containsDenseElement(id.toInt())) ||
// R&T wrappers are non-extensible, but we still want to be
// able to lazily resolve their properties. We can
// special-case them to allow doing so.
IF_RECORD_TUPLE(IsExtendedPrimitiveWrapper(*obj), false));
if (!Watchtower::watchPropertyAdd(cx, obj, id)) {
return false;
}
if (!maybeConvertToDictionaryForAdd(cx, obj)) {
return false;
}
if (auto* shape = LookupShapeForAdd(obj->shape(), id, flags, slot)) {
return obj->setShapeAndAddNewSlot(cx, shape, *slot);
}
if (obj->inDictionaryMode()) {
// First generate a new dictionary shape so that the map and shape can be
// mutated without having to worry about OOM conditions.
if (!NativeObject::generateNewDictionaryShape(cx, obj)) {
return false;
}
if (!allocDictionarySlot(cx, obj, slot)) {
return false;
}
ObjectFlags objectFlags = obj->shape()->objectFlags();
const JSClass* clasp = obj->shape()->getObjectClass();
Rooted<DictionaryPropMap*> map(cx, obj->shape()->propMap()->asDictionary());
uint32_t mapLength = obj->shape()->propMapLength();
if (!DictionaryPropMap::addProperty(cx, clasp, &map, &mapLength, id, flags,
*slot, &objectFlags)) {
return false;
}
obj->dictionaryShape()->updateNewShape(objectFlags, map, mapLength);
return true;
}
ObjectFlags objectFlags = obj->shape()->objectFlags();
const JSClass* clasp = obj->shape()->getObjectClass();
Rooted<SharedPropMap*> map(cx, obj->sharedShape()->propMap());
uint32_t mapLength = obj->shape()->propMapLength();
if (!SharedPropMap::addProperty(cx, clasp, &map, &mapLength, id, flags,
&objectFlags, slot)) {
return false;
}
bool allocatedNewShape;
SharedShape* newShape = SharedShape::getPropMapShape(
cx, obj->shape()->base(), obj->shape()->numFixedSlots(), map, mapLength,
objectFlags, &allocatedNewShape);
if (!newShape) {
return false;
}
Shape* oldShape = obj->shape();
if (!obj->setShapeAndAddNewSlot(cx, newShape, *slot)) {
return false;
}
// Add the new shape to the old shape's shape cache, to optimize this shape
// transition. Don't do this if we just allocated a new shape, because that
// suggests this may not be a hot transition that would benefit from the
// cache.
if (allocatedNewShape) {
return true;
}
if (!RegisterShapeCache(cx, oldShape)) {
// Ignore OOM, the cache is just an optimization.
return true;
}
ShapeCachePtr& cache = oldShape->cacheRef();
if (!cache.isForAdd()) {
cache.setSingleShapeForAdd(newShape);
} else if (cache.isSingleShapeForAdd()) {
SharedShape* prevShape = cache.toSingleShapeForAdd();
if (ShapeSetForAdd* set = MakeShapeSetForAdd(prevShape, newShape)) {
cache.setShapeSetForAdd(set);
AddCellMemory(oldShape, sizeof(ShapeSetForAdd),
MemoryUse::ShapeSetForAdd);
}
} else {
ShapeForAddHasher::Lookup lookup(id, flags);
(void)cache.toShapeSetForAdd()->putNew(lookup, newShape);
}
return true;
}
void Shape::maybeCacheIterator(JSContext* cx, PropertyIteratorObject* iter) {
if (!cache().isNone() && !cache().isIterator()) {
// If we're already caching other shape data, skip caching the iterator.
return;
}
if (MOZ_UNLIKELY(!RegisterShapeCache(cx, this))) {
// Ignore OOM. The cache is just an optimization.
return;
}
cacheRef().setIterator(iter);
}
/* static */
bool NativeObject::addPropertyInReservedSlot(JSContext* cx,
Handle<NativeObject*> obj,
HandleId id, uint32_t slot,
PropertyFlags flags) {
AutoCheckShapeConsistency check(obj);
MOZ_ASSERT(!flags.isCustomDataProperty(),
"Use addCustomDataProperty for custom data properties");
// The slot must be a reserved slot.
MOZ_ASSERT(slot < JSCLASS_RESERVED_SLOTS(obj->getClass()));
// The object must not contain a property named |id| and must be extensible.
MOZ_ASSERT(!id.isVoid());
MOZ_ASSERT(!obj->containsPure(id));
MOZ_ASSERT(!id.isPrivateName());
MOZ_ASSERT(obj->isExtensible());
// The object must not be in dictionary mode. This simplifies the code below.
MOZ_ASSERT(!obj->inDictionaryMode());
// We don't need to call Watchtower::watchPropertyAdd here because this isn't
// used for any watched objects.
MOZ_ASSERT(!Watchtower::watchesPropertyAdd(obj));
ObjectFlags objectFlags = obj->shape()->objectFlags();
const JSClass* clasp = obj->shape()->getObjectClass();
Rooted<SharedPropMap*> map(cx, obj->sharedShape()->propMap());
uint32_t mapLength = obj->shape()->propMapLength();
if (!SharedPropMap::addPropertyInReservedSlot(cx, clasp, &map, &mapLength, id,
flags, slot, &objectFlags)) {
return false;
}
Shape* shape = SharedShape::getPropMapShape(cx, obj->shape()->base(),
obj->shape()->numFixedSlots(),
map, mapLength, objectFlags);
if (!shape) {
return false;
}
obj->setShape(shape);
MOZ_ASSERT(obj->getLastProperty().slot() == slot);
return true;
}
/*
* Assert some invariants that should hold when changing properties. It's the
* responsibility of the callers to ensure these hold.
*/
static void AssertCanChangeFlags(PropertyInfo prop, PropertyFlags flags) {
#ifdef DEBUG
if (prop.configurable()) {
return;
}
// A non-configurable property must stay non-configurable.
MOZ_ASSERT(!flags.configurable());
// Reject attempts to turn a non-configurable data property into an accessor
// or custom data property.
MOZ_ASSERT_IF(prop.isDataProperty(), flags.isDataProperty());
// Reject attempts to turn a non-configurable accessor property into a data
// property or custom data property.
MOZ_ASSERT_IF(prop.isAccessorProperty(), flags.isAccessorProperty());
#endif
}
static void AssertValidArrayIndex(NativeObject* obj, jsid id) {
#ifdef DEBUG
if (obj->is<ArrayObject>()) {
ArrayObject* arr = &obj->as<ArrayObject>();
uint32_t index;
if (IdIsIndex(id, &index)) {
MOZ_ASSERT(index < arr->length() || arr->lengthIsWritable());
}
}
#endif
}
/* static */
bool NativeObject::changeProperty(JSContext* cx, Handle<NativeObject*> obj,
HandleId id, PropertyFlags flags,
uint32_t* slotOut) {
MOZ_ASSERT(!id.isVoid());
AutoCheckShapeConsistency check(obj);
AssertValidArrayIndex(obj, id);
MOZ_ASSERT(!flags.isCustomDataProperty(),
"Use changeCustomDataPropAttributes for custom data properties");
if (!Watchtower::watchPropertyChange(cx, obj, id, flags)) {
return false;
}
Rooted<PropMap*> map(cx, obj->shape()->propMap());
uint32_t mapLength = obj->shape()->propMapLength();
uint32_t propIndex;
Rooted<PropMap*> propMap(cx, map->lookup(cx, mapLength, id, &propIndex));
MOZ_ASSERT(propMap);
ObjectFlags objectFlags = obj->shape()->objectFlags();
PropertyInfo oldProp = propMap->getPropertyInfo(propIndex);
AssertCanChangeFlags(oldProp, flags);
if (oldProp.isAccessorProperty()) {
objectFlags.setFlag(ObjectFlag::HadGetterSetterChange);
}
// If the property flags are not changing, the only thing we have to do is
// update the object flags. This prevents a dictionary mode conversion below.
if (oldProp.flags() == flags) {
*slotOut = oldProp.slot();
if (objectFlags == obj->shape()->objectFlags()) {
return true;
}
return Shape::replaceShape(cx, obj, objectFlags, obj->shape()->proto(),
obj->shape()->numFixedSlots());
}
const JSClass* clasp = obj->shape()->getObjectClass();
if (map->isShared()) {
// Fast path for changing the last property in a SharedPropMap. Call
// getPrevious to "remove" the last property and then call addProperty
// to re-add the last property with the new flags.
if (propMap == map && propIndex == mapLength - 1) {
MOZ_ASSERT(obj->getLastProperty().key() == id);
Rooted<SharedPropMap*> sharedMap(cx, map->asShared());
SharedPropMap::getPrevious(&sharedMap, &mapLength);
if (MOZ_LIKELY(oldProp.hasSlot())) {
*slotOut = oldProp.slot();
if (!SharedPropMap::addPropertyWithKnownSlot(cx, clasp, &sharedMap,
&mapLength, id, flags,
*slotOut, &objectFlags)) {
return false;
}
} else {
if (!SharedPropMap::addProperty(cx, clasp, &sharedMap, &mapLength, id,
flags, &objectFlags, slotOut)) {
return false;
}
}
SharedShape* newShape = SharedShape::getPropMapShape(
cx, obj->shape()->base(), obj->shape()->numFixedSlots(), sharedMap,
mapLength, objectFlags);
if (!newShape) {
return false;
}
if (MOZ_LIKELY(oldProp.hasSlot())) {
MOZ_ASSERT(obj->sharedShape()->slotSpan() == newShape->slotSpan());
obj->setShape(newShape);
return true;
}
return obj->setShapeAndAddNewSlot(cx, newShape, *slotOut);
}
// Changing a non-last property. Switch to dictionary mode and relookup
// pointers for the new dictionary map.
if (!NativeObject::toDictionaryMode(cx, obj)) {
return false;
}
map = obj->shape()->propMap();
propMap = map->lookup(cx, mapLength, id, &propIndex);
MOZ_ASSERT(propMap);
} else {
if (!NativeObject::generateNewDictionaryShape(cx, obj)) {
return false;
}
}
// The object has a new dictionary shape (see toDictionaryMode and
// generateNewDictionaryShape calls above), so we can mutate the map and shape
// in place.
MOZ_ASSERT(map->isDictionary());
MOZ_ASSERT(propMap->isDictionary());
uint32_t slot = oldProp.hasSlot() ? oldProp.slot() : SHAPE_INVALID_SLOT;
if (slot == SHAPE_INVALID_SLOT) {
if (!allocDictionarySlot(cx, obj, &slot)) {
return false;
}
}
propMap->asDictionary()->changeProperty(cx, clasp, propIndex, flags, slot,
&objectFlags);
obj->dictionaryShape()->setObjectFlagsOfNewShape(objectFlags);
*slotOut = slot;
return true;
}
/* static */
bool NativeObject::changeCustomDataPropAttributes(JSContext* cx,
Handle<NativeObject*> obj,
HandleId id,
PropertyFlags flags) {
MOZ_ASSERT(!id.isVoid());
AutoCheckShapeConsistency check(obj);
AssertValidArrayIndex(obj, id);
AssertValidCustomDataProp(obj, flags);
if (!Watchtower::watchPropertyChange(cx, obj, id, flags)) {
return false;
}
Rooted<PropMap*> map(cx, obj->shape()->propMap());
uint32_t mapLength = obj->shape()->propMapLength();
uint32_t propIndex;
Rooted<PropMap*> propMap(cx, map->lookup(cx, mapLength, id, &propIndex));
MOZ_ASSERT(propMap);
PropertyInfo oldProp = propMap->getPropertyInfo(propIndex);
MOZ_ASSERT(oldProp.isCustomDataProperty());
AssertCanChangeFlags(oldProp, flags);
// If the property flags are not changing, we're done.
if (oldProp.flags() == flags) {
return true;
}
const JSClass* clasp = obj->shape()->getObjectClass();
ObjectFlags objectFlags = obj->shape()->objectFlags();
if (map->isShared()) {
// Fast path for changing the last property in a SharedPropMap. Call
// getPrevious to "remove" the last property and then call
// addCustomDataProperty to re-add the last property with the new flags.
if (propMap == map && propIndex == mapLength - 1) {
MOZ_ASSERT(obj->getLastProperty().key() == id);
Rooted<SharedPropMap*> sharedMap(cx, map->asShared());
SharedPropMap::getPrevious(&sharedMap, &mapLength);
if (!SharedPropMap::addCustomDataProperty(
cx, clasp, &sharedMap, &mapLength, id, flags, &objectFlags)) {
return false;
}
Shape* newShape = SharedShape::getPropMapShape(
cx, obj->shape()->base(), obj->shape()->numFixedSlots(), sharedMap,
mapLength, objectFlags);
if (!newShape) {
return false;
}
obj->setShape(newShape);
return true;
}
// Changing a non-last property. Switch to dictionary mode and relookup
// pointers for the new dictionary map.
if (!NativeObject::toDictionaryMode(cx, obj)) {
return false;
}
map = obj->shape()->propMap();
propMap = map->lookup(cx, mapLength, id, &propIndex);
MOZ_ASSERT(propMap);
} else {
if (!NativeObject::generateNewDictionaryShape(cx, obj)) {
return false;
}
}
// The object has a new dictionary shape (see toDictionaryMode and
// generateNewDictionaryShape calls above), so we can mutate the map and shape
// in place.
MOZ_ASSERT(map->isDictionary());
MOZ_ASSERT(propMap->isDictionary());
propMap->asDictionary()->changePropertyFlags(cx, clasp, propIndex, flags,
&objectFlags);
obj->dictionaryShape()->setObjectFlagsOfNewShape(objectFlags);
return true;
}
void NativeObject::maybeFreeDictionaryPropSlots(JSContext* cx,
DictionaryPropMap* map,
uint32_t mapLength) {
// We can free all non-reserved slots if there are no properties left. We also
// handle the case where there's a single slotless property, to support arrays
// (array.length is a custom data property).
MOZ_ASSERT(dictionaryShape()->propMap() == map);
MOZ_ASSERT(shape()->propMapLength() == mapLength);
if (mapLength > 1 || map->previous()) {
return;
}
if (mapLength == 1 && map->getPropertyInfo(0).hasSlot()) {
return;
}
uint32_t oldSpan = dictionaryModeSlotSpan();
uint32_t newSpan = JSCLASS_RESERVED_SLOTS(getClass());
if (oldSpan == newSpan) {
return;
}
MOZ_ASSERT(newSpan < oldSpan);
// Trigger write barriers on the old slots before reallocating.
prepareSlotRangeForOverwrite(newSpan, oldSpan);
invalidateSlotRange(newSpan, oldSpan);
uint32_t oldCapacity = numDynamicSlots();
uint32_t newCapacity =
calculateDynamicSlots(numFixedSlots(), newSpan, getClass());
if (newCapacity < oldCapacity) {
shrinkSlots(cx, oldCapacity, newCapacity);
}
setDictionaryModeSlotSpan(newSpan);
map->setFreeList(SHAPE_INVALID_SLOT);
}
void NativeObject::setShapeAndRemoveLastSlot(JSContext* cx,
SharedShape* newShape,
uint32_t slot) {
MOZ_ASSERT(!inDictionaryMode());
MOZ_ASSERT(newShape->isShared());
MOZ_ASSERT(newShape->slotSpan() == slot);
uint32_t numFixed = newShape->numFixedSlots();
if (slot < numFixed) {
setFixedSlot(slot, UndefinedValue());
} else {
setDynamicSlot(numFixed, slot, UndefinedValue());
uint32_t oldCapacity = numDynamicSlots();
uint32_t newCapacity = calculateDynamicSlots(numFixed, slot, getClass());
MOZ_ASSERT(newCapacity <= oldCapacity);
if (newCapacity < oldCapacity) {
shrinkSlots(cx, oldCapacity, newCapacity);
}
}
setShape(newShape);
}
/* static */
bool NativeObject::removeProperty(JSContext* cx, Handle<NativeObject*> obj,
HandleId id) {
AutoCheckShapeConsistency check(obj);
Rooted<PropMap*> map(cx, obj->shape()->propMap());
uint32_t mapLength = obj->shape()->propMapLength();
AutoKeepPropMapTables keep(cx);
PropMapTable* table;
PropMapTable::Ptr ptr;
Rooted<PropMap*> propMap(cx);
uint32_t propIndex;
if (!PropMap::lookupForRemove(cx, map, mapLength, id, keep, propMap.address(),
&propIndex, &table, &ptr)) {
return false;
}
if (!propMap) {
return true;
}
if (!Watchtower::watchPropertyRemove(cx, obj, id)) {
return false;
}
PropertyInfo prop = propMap->getPropertyInfo(propIndex);
// If we're removing an accessor property, ensure the HadGetterSetterChange
// object flag is set. This is necessary because the slot holding the
// GetterSetter can be changed indirectly by removing the property and then
// adding it back with a different GetterSetter value but the same shape.
if (prop.isAccessorProperty() && !obj->hadGetterSetterChange()) {
if (!NativeObject::setHadGetterSetterChange(cx, obj)) {
return false;
}
}
if (map->isShared()) {
// Fast path for removing the last property from a SharedPropMap. In this
// case we can just call getPrevious and then look up a shape for the
// resulting map/mapLength.
if (propMap == map && propIndex == mapLength - 1) {