Source code
Revision control
Copy as Markdown
Other Tools
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
use super::incoming::IncomingApplicator;
use super::record::{
BookmarkItemRecord, BookmarkRecord, BookmarkRecordId, FolderRecord, QueryRecord,
SeparatorRecord,
};
use super::{SyncedBookmarkKind, SyncedBookmarkValidity};
use crate::db::{GlobalChangeCounterTracker, PlacesDb, SharedPlacesDb};
use crate::error::*;
use crate::frecency::{calculate_frecency, DEFAULT_FRECENCY_SETTINGS};
use crate::storage::{
bookmarks::{
bookmark_sync::{create_synced_bookmark_roots, reset},
BookmarkRootGuid,
},
delete_pending_temp_tables, get_meta, put_meta,
};
use crate::types::{BookmarkType, SyncStatus, UnknownFields};
use dogear::{
self, AbortSignal, CompletionOps, Content, Item, MergedRoot, TelemetryEvent, Tree, UploadItem,
UploadTombstone,
};
use interrupt_support::SqlInterruptScope;
use rusqlite::ErrorCode;
use rusqlite::Row;
use sql_support::ConnExt;
use std::cell::RefCell;
use std::collections::HashMap;
use std::fmt;
use std::sync::Arc;
use sync15::bso::{IncomingBso, OutgoingBso};
use sync15::engine::{CollSyncIds, CollectionRequest, EngineSyncAssociation, SyncEngine};
use sync15::{telemetry, CollectionName, ServerTimestamp};
use sync_guid::Guid as SyncGuid;
use types::Timestamp;
pub const LAST_SYNC_META_KEY: &str = "bookmarks_last_sync_time";
// Note that all engines in this crate should use a *different* meta key
// for the global sync ID, because engines are reset individually.
pub const GLOBAL_SYNCID_META_KEY: &str = "bookmarks_global_sync_id";
pub const COLLECTION_SYNCID_META_KEY: &str = "bookmarks_sync_id";
pub const COLLECTION_NAME: &str = "bookmarks";
/// The maximum number of URLs for which to recalculate frecencies at once.
/// This is a trade-off between write efficiency and transaction time: higher
/// maximums mean fewer write statements, but longer transactions, possibly
/// blocking writes from other connections.
const MAX_FRECENCIES_TO_RECALCULATE_PER_CHUNK: usize = 400;
/// Adapts an interruptee to a Dogear abort signal.
struct MergeInterruptee<'a>(&'a SqlInterruptScope);
impl AbortSignal for MergeInterruptee<'_> {
#[inline]
fn aborted(&self) -> bool {
self.0.was_interrupted()
}
}
fn stage_incoming(
db: &PlacesDb,
scope: &SqlInterruptScope,
inbound: Vec<IncomingBso>,
incoming_telemetry: &mut telemetry::EngineIncoming,
) -> Result<()> {
let mut tx = db.begin_transaction()?;
let applicator = IncomingApplicator::new(db);
for incoming in inbound {
applicator.apply_bso(incoming)?;
incoming_telemetry.applied(1);
if tx.should_commit() {
// Trigger frecency updates for all new origins.
debug!("Updating origins for new synced URLs since last commit");
delete_pending_temp_tables(db)?;
}
tx.maybe_commit()?;
scope.err_if_interrupted()?;
}
debug!("Updating origins for new synced URLs in last chunk");
delete_pending_temp_tables(db)?;
tx.commit()?;
Ok(())
}
fn db_has_changes(db: &PlacesDb) -> Result<bool> {
// In the first subquery, we check incoming items with needsMerge = true
// except the tombstones who don't correspond to any local bookmark because
let sql = format!(
"SELECT
EXISTS (
SELECT 1
FROM moz_bookmarks_synced v
LEFT JOIN moz_bookmarks b ON v.guid = b.guid
WHERE v.needsMerge AND
(NOT v.isDeleted OR b.guid NOT NULL)
) OR EXISTS (
WITH RECURSIVE
{}
SELECT 1
FROM localItems
WHERE syncChangeCounter > 0
) OR EXISTS (
SELECT 1
FROM moz_bookmarks_deleted
)
AS hasChanges",
LocalItemsFragment("localItems")
);
Ok(db
.try_query_row(
&sql,
[],
|row| -> rusqlite::Result<_> { row.get::<_, bool>(0) },
false,
)?
.unwrap_or(false))
}
/// Builds a temporary table with the merge states of all nodes in the merged
/// tree, then updates the local tree to match the merged tree.
///
/// Conceptually, we examine the merge state of each item, and either leave the
/// item unchanged, upload the local side, apply the remote side, or apply and
/// then reupload the remote side with a new structure.
fn update_local_items_in_places(
db: &PlacesDb,
scope: &SqlInterruptScope,
now: Timestamp,
ops: &CompletionOps<'_>,
) -> Result<()> {
// Build a table of new and updated items.
debug!(
"Staging apply {} remote item ops",
ops.apply_remote_items.len()
);
sql_support::each_sized_chunk(
&ops.apply_remote_items,
sql_support::default_max_variable_number() / 3,
|chunk, _| -> Result<()> {
// CTEs in `WITH` clauses aren't indexed, so this query needs a
// full table scan on `ops`. But that's okay; a separate temp
// table for ops would also need a full scan. Note that we need
// both the local _and_ remote GUIDs here, because we haven't
// changed the local GUIDs yet.
let sql = format!(
"WITH ops(mergedGuid, localGuid, remoteGuid, remoteType,
level) AS (
VALUES {ops}
)
INSERT INTO itemsToApply(mergedGuid, localId, remoteId,
remoteGuid, newLevel, newKind,
localDateAdded, remoteDateAdded,
lastModified, oldTitle, newTitle,
oldPlaceId, newPlaceId,
newKeyword)
SELECT n.mergedGuid, b.id, v.id,
v.guid, n.level, n.remoteType,
b.dateAdded, v.dateAdded,
v.serverModified, b.title, v.title,
b.fk, v.placeId,
v.keyword
FROM ops n
JOIN moz_bookmarks_synced v ON v.guid = n.remoteGuid
LEFT JOIN moz_bookmarks b ON b.guid = n.localGuid",
ops = sql_support::repeat_display(chunk.len(), ",", |index, f| {
let op = &chunk[index];
write!(
f,
"(?, ?, ?, {}, {})",
SyncedBookmarkKind::from(op.remote_node().kind) as u8,
op.level
)
}),
);
// We can't avoid allocating here, since we're binding four
// parameters per descendant. Rust's `SliceConcatExt::concat`
// is semantically equivalent, but requires a second allocation,
// which we _can_ avoid by writing this out.
let mut params = Vec::with_capacity(chunk.len() * 3);
for op in chunk.iter() {
scope.err_if_interrupted()?;
let merged_guid = op.merged_node.guid.as_str();
params.push(Some(merged_guid));
let local_guid = op
.merged_node
.merge_state
.local_node()
.map(|node| node.guid.as_str());
params.push(local_guid);
let remote_guid = op.remote_node().guid.as_str();
params.push(Some(remote_guid));
}
db.execute(&sql, rusqlite::params_from_iter(params))?;
Ok(())
},
)?;
debug!("Staging {} change GUID ops", ops.change_guids.len());
sql_support::each_sized_chunk(
&ops.change_guids,
sql_support::default_max_variable_number() / 2,
|chunk, _| -> Result<()> {
let sql = format!(
"INSERT INTO changeGuidOps(localGuid, mergedGuid,
syncStatus, level, lastModified)
VALUES {}",
sql_support::repeat_display(chunk.len(), ",", |index, f| {
let op = &chunk[index];
// If only the local GUID changed, the item was deduped, so we
// can mark it as syncing. Otherwise, we changed an invalid
// GUID locally or remotely, so we leave its original sync
// status in place until we've uploaded it.
let sync_status = if op.merged_node.remote_guid_changed() {
None
} else {
Some(SyncStatus::Normal as u8)
};
write!(
f,
"(?, ?, {}, {}, {})",
NullableFragment(sync_status),
op.level,
now
)
}),
);
let mut params = Vec::with_capacity(chunk.len() * 2);
for op in chunk.iter() {
scope.err_if_interrupted()?;
let local_guid = op.local_node().guid.as_str();
params.push(local_guid);
let merged_guid = op.merged_node.guid.as_str();
params.push(merged_guid);
}
db.execute(&sql, rusqlite::params_from_iter(params))?;
Ok(())
},
)?;
debug!(
"Staging apply {} new local structure ops",
ops.apply_new_local_structure.len()
);
sql_support::each_sized_chunk(
&ops.apply_new_local_structure,
sql_support::default_max_variable_number() / 2,
|chunk, _| -> Result<()> {
let sql = format!(
"INSERT INTO applyNewLocalStructureOps(
mergedGuid, mergedParentGuid, position, level
)
VALUES {}",
sql_support::repeat_display(chunk.len(), ",", |index, f| {
let op = &chunk[index];
write!(f, "(?, ?, {}, {})", op.position, op.level)
}),
);
let mut params = Vec::with_capacity(chunk.len() * 2);
for op in chunk.iter() {
scope.err_if_interrupted()?;
let merged_guid = op.merged_node.guid.as_str();
params.push(merged_guid);
let merged_parent_guid = op.merged_parent_node.guid.as_str();
params.push(merged_parent_guid);
}
db.execute(&sql, rusqlite::params_from_iter(params))?;
Ok(())
},
)?;
debug!(
"Removing {} tombstones for revived items",
ops.delete_local_tombstones.len()
);
sql_support::each_chunk_mapped(
&ops.delete_local_tombstones,
|op| op.guid().as_str(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"DELETE FROM moz_bookmarks_deleted
WHERE guid IN ({})",
sql_support::repeat_sql_vars(chunk.len())
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
debug!(
"Inserting {} new tombstones for non-syncable and invalid items",
ops.insert_local_tombstones.len()
);
sql_support::each_chunk_mapped(
&ops.insert_local_tombstones,
|op| op.remote_node().guid.as_str().to_owned(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"INSERT INTO moz_bookmarks_deleted(guid, dateRemoved)
VALUES {}",
sql_support::repeat_display(chunk.len(), ",", |_, f| write!(f, "(?, {})", now)),
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
debug!(
"Flag frecencies for {} removed bookmark URLs as stale",
ops.delete_local_items.len()
);
sql_support::each_chunk_mapped(
&ops.delete_local_items,
|op| op.local_node().guid.as_str().to_owned(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"REPLACE INTO moz_places_stale_frecencies(
place_id, stale_at
)
SELECT b.fk, {now}
FROM moz_bookmarks b
WHERE b.guid IN ({vars})
AND b.fk NOT NULL",
now = now,
vars = sql_support::repeat_sql_vars(chunk.len())
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
debug!(
"Removing {} deleted items from Places",
ops.delete_local_items.len()
);
sql_support::each_chunk_mapped(
&ops.delete_local_items,
|op| op.local_node().guid.as_str().to_owned(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"DELETE FROM moz_bookmarks
WHERE guid IN ({})",
sql_support::repeat_sql_vars(chunk.len())
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
debug!("Changing GUIDs");
scope.err_if_interrupted()?;
db.execute_batch("DELETE FROM changeGuidOps")?;
debug!("Applying remote items");
apply_remote_items(db, scope, now)?;
// Fires the `applyNewLocalStructure` trigger.
debug!("Applying new local structure");
scope.err_if_interrupted()?;
db.execute_batch("DELETE FROM applyNewLocalStructureOps")?;
// Similar to the check in apply_remote_items, however we do a post check
// to see if dogear was unable to fix up the issue
let orphaned_count: i64 = db.query_row(
"WITH RECURSIVE orphans(id) AS (
SELECT b.id
FROM moz_bookmarks b
WHERE b.parent IS NOT NULL
AND NOT EXISTS (
SELECT 1 FROM moz_bookmarks p WHERE p.id = b.parent
)
UNION
SELECT c.id
FROM moz_bookmarks c
JOIN orphans o ON c.parent = o.id
)
SELECT COUNT(*) FROM orphans;",
[],
|row| row.get(0),
)?;
if orphaned_count > 0 {
warn!("Found {} orphaned bookmarks after sync", orphaned_count);
error_support::report_error!(
"places-sync-bookmarks-orphaned",
"found local orphaned bookmarks after we applied new local structure ops: {}",
orphaned_count,
);
}
debug!(
"Resetting change counters for {} items that shouldn't be uploaded",
ops.set_local_merged.len()
);
sql_support::each_chunk_mapped(
&ops.set_local_merged,
|op| op.merged_node.guid.as_str(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"UPDATE moz_bookmarks SET
syncChangeCounter = 0
WHERE guid IN ({})",
sql_support::repeat_sql_vars(chunk.len()),
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
debug!(
"Bumping change counters for {} items that should be uploaded",
ops.set_local_unmerged.len()
);
sql_support::each_chunk_mapped(
&ops.set_local_unmerged,
|op| op.merged_node.guid.as_str(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"UPDATE moz_bookmarks SET
syncChangeCounter = 1
WHERE guid IN ({})",
sql_support::repeat_sql_vars(chunk.len()),
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
debug!(
"Flagging applied {} remote items as merged",
ops.set_remote_merged.len()
);
sql_support::each_chunk_mapped(
&ops.set_remote_merged,
|op| op.guid().as_str(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"UPDATE moz_bookmarks_synced SET
needsMerge = 0
WHERE guid IN ({})",
sql_support::repeat_sql_vars(chunk.len()),
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
Ok(())
}
fn apply_remote_items(db: &PlacesDb, scope: &SqlInterruptScope, now: Timestamp) -> Result<()> {
// Remove all keywords from old and new URLs, and remove new keywords
// from all existing URLs. The `NOT NULL` conditions are important; they
// ensure that SQLite uses our partial indexes on `itemsToApply`,
// instead of a table scan.
debug!("Removing old keywords");
scope.err_if_interrupted()?;
db.execute_batch(
"DELETE FROM moz_keywords
WHERE place_id IN (SELECT oldPlaceId FROM itemsToApply
WHERE oldPlaceId NOT NULL) OR
place_id IN (SELECT newPlaceId FROM itemsToApply
WHERE newPlaceId NOT NULL) OR
keyword IN (SELECT newKeyword FROM itemsToApply
WHERE newKeyword NOT NULL)",
)?;
debug!("Removing old tags");
scope.err_if_interrupted()?;
db.execute_batch(
"DELETE FROM moz_tags_relation
WHERE place_id IN (SELECT oldPlaceId FROM itemsToApply
WHERE oldPlaceId NOT NULL) OR
place_id IN (SELECT newPlaceId FROM itemsToApply
WHERE newPlaceId NOT NULL)",
)?;
// guids are colliding as it could shed light on what's going on
debug!("Checking for potential GUID collisions before upserting items");
let collision_check_sql = "
SELECT ia.localId, ia.mergedGuid, ia.remoteGuid, b.id, b.guid
FROM itemsToApply ia
JOIN moz_bookmarks b ON ia.mergedGuid = b.guid
WHERE (ia.localId IS NULL OR ia.localId != b.id)
";
let potential_collisions: Vec<(Option<i64>, String, String, i64, String)> = db
.prepare(collision_check_sql)?
.query_map([], |row| {
let ia_local_id: Option<i64> = row.get(0)?;
let ia_merged_guid: String = row.get(1)?;
let ia_remote_guid: String = row.get(2)?;
let bmk_id: i64 = row.get(3)?;
let bmk_guid: String = row.get(4)?;
Ok((
ia_local_id,
ia_merged_guid,
ia_remote_guid,
bmk_id,
bmk_guid,
))
})?
.filter_map(|entry| entry.ok())
.collect();
if !potential_collisions.is_empty() {
// Log details about the collisions
for (ia_local_id, ia_merged_guid, ia_remote_guid, bmk_id, bmk_guid) in &potential_collisions
{
error_support::breadcrumb!(
"Found GUID collision: ia_localId={:?}, ia_mergedGuid={}, ia_remoteGuid={}, mb_id={}, mb_guid={}",
ia_local_id,
ia_merged_guid,
ia_remote_guid,
bmk_id,
bmk_guid
);
}
}
// undetected orphaned bookmarks and report them
let orphaned_count: i64 = db.query_row(
"WITH RECURSIVE orphans(id) AS (
SELECT b.id
FROM moz_bookmarks b
WHERE b.parent IS NOT NULL
AND NOT EXISTS (
SELECT 1 FROM moz_bookmarks p WHERE p.id = b.parent
)
UNION
SELECT c.id
FROM moz_bookmarks c
JOIN orphans o ON c.parent = o.id
)
SELECT COUNT(*) FROM orphans;",
[],
|row| row.get(0),
)?;
if orphaned_count > 0 {
warn!("Found {} orphaned bookmarks during sync", orphaned_count);
error_support::breadcrumb!(
"places-sync-bookmarks-orphaned: found local orphans before upsert {}",
orphaned_count
);
}
// Insert and update items, temporarily using the Places root for new
// items' parent IDs, and -1 for positions. We'll fix these up later,
// when we apply the new local structure. This `INSERT` is a full table
// scan on `itemsToApply`. The no-op `WHERE` clause is necessary to
// avoid a parsing ambiguity.
debug!("Upserting new items");
let upsert_sql = format!(
"INSERT INTO moz_bookmarks(id, guid, parent,
position, type, fk, title,
dateAdded,
lastModified,
syncStatus, syncChangeCounter)
SELECT localId, mergedGuid, (SELECT id FROM moz_bookmarks
WHERE guid = '{root_guid}'),
-1, {type_fragment}, newPlaceId, newTitle,
/* Pick the older of the local and remote date added. We'll
weakly reupload any items with an older local date. */
MIN(IFNULL(localDateAdded, remoteDateAdded), remoteDateAdded),
/* The last modified date should always be newer than the date
added, so we pick the newer of the two here. */
MAX(lastModified, remoteDateAdded),
{sync_status}, 0
FROM itemsToApply
WHERE 1
ON CONFLICT(id) DO UPDATE SET
title = excluded.title,
dateAdded = excluded.dateAdded,
lastModified = excluded.lastModified,
fk = excluded.fk,
syncStatus = {sync_status}
* incoming records BUT for one reason or another dogear doesn't believe it exists locally
* This handles the case where we try to insert a new bookmark with a GUID that already exists,
* updating the existing record instead of failing with a constraint violation.
* Usually the above conflict will catch most of these scenarios and there's no issue of
* any dupes being added here since users that hit this before would've just failed the bookmark sync
*/
ON CONFLICT(guid) DO UPDATE SET
title = excluded.title,
dateAdded = excluded.dateAdded,
lastModified = excluded.lastModified,
fk = excluded.fk,
syncStatus = {sync_status}",
root_guid = BookmarkRootGuid::Root.as_guid().as_str(),
type_fragment = ItemTypeFragment("newKind"),
sync_status = SyncStatus::Normal as u8,
);
scope.err_if_interrupted()?;
let result = db.execute_batch(&upsert_sql);
// guid collisions, we want to report on this during the upsert to see
// if we can discern any obvious signs
if let Err(rusqlite::Error::SqliteFailure(e, _)) = &result {
if e.code == ErrorCode::ConstraintViolation {
error_support::report_error!(
"places-sync-bookmarks-constraint-violation",
"Hit a constraint violation {:?}",
result
);
}
}
// Return the original result
result?;
debug!("Flagging frecencies for recalculation");
scope.err_if_interrupted()?;
db.execute_batch(&format!(
"REPLACE INTO moz_places_stale_frecencies(place_id, stale_at)
SELECT oldPlaceId, {now} FROM itemsToApply
WHERE newKind = {bookmark_kind} AND (
oldPlaceId IS NULL <> newPlaceId IS NULL OR
oldPlaceId <> newPlaceId
)
UNION ALL
SELECT newPlaceId, {now} FROM itemsToApply
WHERE newKind = {bookmark_kind} AND (
newPlaceId IS NULL <> oldPlaceId IS NULL OR
newPlaceId <> oldPlaceId
)",
now = now,
bookmark_kind = SyncedBookmarkKind::Bookmark as u8,
))?;
debug!("Inserting new keywords for new URLs");
scope.err_if_interrupted()?;
db.execute_batch(
"INSERT OR IGNORE INTO moz_keywords(keyword, place_id)
SELECT newKeyword, newPlaceId
FROM itemsToApply
WHERE newKeyword NOT NULL",
)?;
debug!("Inserting new tags for new URLs");
scope.err_if_interrupted()?;
db.execute_batch(
"INSERT OR IGNORE INTO moz_tags_relation(tag_id, place_id)
SELECT r.tagId, n.newPlaceId
FROM itemsToApply n
JOIN moz_bookmarks_synced_tag_relation r ON r.itemId = n.remoteId",
)?;
Ok(())
}
/// Stores a snapshot of all locally changed items in a temporary table for
/// upload. This is called from within the merge transaction, to ensure that
/// changes made during the sync don't cause us to upload inconsistent
/// records.
///
/// Conceptually, `itemsToUpload` is a transient "view" of locally changed
/// items. The local change counter is the persistent record of items that
/// we need to upload, so, if upload is interrupted or fails, we'll stage
/// the items again on the next sync.
fn stage_items_to_upload(
db: &PlacesDb,
scope: &SqlInterruptScope,
upload_items: &[UploadItem<'_>],
upload_tombstones: &[UploadTombstone<'_>],
) -> Result<()> {
debug!("Cleaning up staged items left from last sync");
scope.err_if_interrupted()?;
db.execute_batch("DELETE FROM itemsToUpload")?;
// Stage remotely changed items with older local creation dates. These are
// tracked "weakly": if the upload is interrupted or fails, we won't
// reupload the record on the next sync.
debug!("Staging items with older local dates added");
scope.err_if_interrupted()?;
db.execute_batch(&format!(
"INSERT OR IGNORE INTO itemsToUpload(id, guid, syncChangeCounter,
parentGuid, parentTitle, dateAdded,
kind, title, placeId, url,
keyword, position)
{}
JOIN itemsToApply n ON n.mergedGuid = b.guid
WHERE n.localDateAdded < n.remoteDateAdded",
UploadItemsFragment("b")
))?;
debug!(
"Staging {} remaining locally changed items for upload",
upload_items.len()
);
sql_support::each_chunk_mapped(
upload_items,
|op| op.merged_node.guid.as_str(),
|chunk, _| -> Result<()> {
let sql = format!(
"INSERT OR IGNORE INTO itemsToUpload(id, guid, syncChangeCounter,
parentGuid, parentTitle,
dateAdded, kind, title,
placeId, url, keyword,
position)
{upload_items_fragment}
WHERE b.guid IN ({vars})",
vars = sql_support::repeat_sql_vars(chunk.len()),
upload_items_fragment = UploadItemsFragment("b")
);
db.execute(&sql, rusqlite::params_from_iter(chunk))?;
Ok(())
},
)?;
// Record the child GUIDs of locally changed folders, which we use to
// populate the `children` array in the record.
debug!("Staging structure to upload");
scope.err_if_interrupted()?;
db.execute_batch(
"INSERT INTO structureToUpload(guid, parentId, position)
SELECT b.guid, b.parent, b.position
FROM moz_bookmarks b
JOIN itemsToUpload o ON o.id = b.parent",
)?;
// Stage tags for outgoing bookmarks.
debug!("Staging tags to upload");
scope.err_if_interrupted()?;
db.execute_batch(
"INSERT INTO tagsToUpload(id, tag)
SELECT o.id, t.tag
FROM itemsToUpload o
JOIN moz_tags_relation r ON r.place_id = o.placeId
JOIN moz_tags t ON t.id = r.tag_id",
)?;
// Finally, stage tombstones for deleted items.
debug!("Staging {} tombstones to upload", upload_tombstones.len());
sql_support::each_chunk_mapped(
upload_tombstones,
|op| op.guid().as_str(),
|chunk, _| -> Result<()> {
scope.err_if_interrupted()?;
db.execute(
&format!(
"INSERT OR IGNORE INTO itemsToUpload(
guid, syncChangeCounter, isDeleted
)
VALUES {}",
sql_support::repeat_display(chunk.len(), ",", |_, f| write!(f, "(?, 1, 1)")),
),
rusqlite::params_from_iter(chunk),
)?;
Ok(())
},
)?;
Ok(())
}
/// Inflates Sync records for all staged outgoing items.
fn fetch_outgoing_records(db: &PlacesDb, scope: &SqlInterruptScope) -> Result<Vec<OutgoingBso>> {
let mut changes = Vec::new();
let mut child_record_ids_by_local_parent_id: HashMap<i64, Vec<BookmarkRecordId>> =
HashMap::new();
let mut tags_by_local_id: HashMap<i64, Vec<String>> = HashMap::new();
let mut stmt = db.prepare(
"SELECT parentId, guid FROM structureToUpload
ORDER BY parentId, position",
)?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
scope.err_if_interrupted()?;
let local_parent_id = row.get::<_, i64>("parentId")?;
let child_guid = row.get::<_, SyncGuid>("guid")?;
let child_record_ids = child_record_ids_by_local_parent_id
.entry(local_parent_id)
.or_default();
child_record_ids.push(child_guid.into());
}
let mut stmt = db.prepare("SELECT id, tag FROM tagsToUpload")?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
scope.err_if_interrupted()?;
let local_id = row.get::<_, i64>("id")?;
let tag = row.get::<_, String>("tag")?;
let tags = tags_by_local_id.entry(local_id).or_default();
tags.push(tag);
}
let mut stmt = db.prepare(
"SELECT i.id, i.syncChangeCounter, i.guid, i.isDeleted, i.kind, i.keyword,
i.url, IFNULL(i.title, '') AS title, i.position, i.parentGuid,
IFNULL(i.parentTitle, '') AS parentTitle, i.dateAdded, m.unknownFields
FROM itemsToUpload i
LEFT JOIN moz_bookmarks_synced m ON i.guid == m.guid
",
)?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
scope.err_if_interrupted()?;
let guid = row.get::<_, SyncGuid>("guid")?;
let is_deleted = row.get::<_, bool>("isDeleted")?;
if is_deleted {
changes.push(OutgoingBso::new_tombstone(
BookmarkRecordId::from(guid).as_guid().clone().into(),
));
continue;
}
let parent_guid = row.get::<_, SyncGuid>("parentGuid")?;
let parent_title = row.get::<_, String>("parentTitle")?;
let date_added = row.get::<_, i64>("dateAdded")?;
let unknown_fields = match row.get::<_, Option<String>>("unknownFields")? {
None => UnknownFields::new(),
Some(s) => serde_json::from_str(&s)?,
};
let record: BookmarkItemRecord = match SyncedBookmarkKind::from_u8(row.get("kind")?)? {
SyncedBookmarkKind::Bookmark => {
let local_id = row.get::<_, i64>("id")?;
let title = row.get::<_, String>("title")?;
let url = row.get::<_, String>("url")?;
BookmarkRecord {
record_id: guid.into(),
parent_record_id: Some(parent_guid.into()),
parent_title: Some(parent_title),
date_added: Some(date_added),
has_dupe: true,
title: Some(title),
url: Some(url),
keyword: row.get::<_, Option<String>>("keyword")?,
tags: tags_by_local_id.remove(&local_id).unwrap_or_default(),
unknown_fields,
}
.into()
}
SyncedBookmarkKind::Query => {
let title = row.get::<_, String>("title")?;
let url = row.get::<_, String>("url")?;
QueryRecord {
record_id: guid.into(),
parent_record_id: Some(parent_guid.into()),
parent_title: Some(parent_title),
date_added: Some(date_added),
has_dupe: true,
title: Some(title),
url: Some(url),
tag_folder_name: None,
unknown_fields,
}
.into()
}
SyncedBookmarkKind::Folder => {
let title = row.get::<_, String>("title")?;
let local_id = row.get::<_, i64>("id")?;
let children = child_record_ids_by_local_parent_id
.remove(&local_id)
.unwrap_or_default();
FolderRecord {
record_id: guid.into(),
parent_record_id: Some(parent_guid.into()),
parent_title: Some(parent_title),
date_added: Some(date_added),
has_dupe: true,
title: Some(title),
children,
unknown_fields,
}
.into()
}
SyncedBookmarkKind::Livemark => continue,
SyncedBookmarkKind::Separator => {
let position = row.get::<_, i64>("position")?;
SeparatorRecord {
record_id: guid.into(),
parent_record_id: Some(parent_guid.into()),
parent_title: Some(parent_title),
date_added: Some(date_added),
has_dupe: true,
position: Some(position),
unknown_fields,
}
.into()
}
};
changes.push(OutgoingBso::from_content_with_id(record)?);
}
Ok(changes)
}
/// Decrements the change counter, updates the sync status, and cleans up
/// tombstones for successfully synced items. Sync calls this method at the
/// end of each bookmark sync.
fn push_synced_items(
db: &PlacesDb,
scope: &SqlInterruptScope,
uploaded_at: ServerTimestamp,
records_synced: Vec<SyncGuid>,
) -> Result<()> {
// Flag all successfully synced records as uploaded. This `UPDATE` fires
// the `pushUploadedChanges` trigger, which updates local change
// counters and writes the items back to the synced bookmarks table.
let mut tx = db.begin_transaction()?;
let guids = records_synced
.into_iter()
.map(|id| BookmarkRecordId::from_payload_id(id).into())
.collect::<Vec<SyncGuid>>();
sql_support::each_chunk(&guids, |chunk, _| -> Result<()> {
db.execute(
&format!(
"UPDATE itemsToUpload SET
uploadedAt = {uploaded_at}
WHERE guid IN ({values})",
uploaded_at = uploaded_at.as_millis(),
values = sql_support::repeat_sql_values(chunk.len())
),
rusqlite::params_from_iter(chunk),
)?;
tx.maybe_commit()?;
scope.err_if_interrupted()?;
Ok(())
})?;
// Fast-forward the last sync time, so that we don't download the
// records we just uploaded on the next sync.
put_meta(db, LAST_SYNC_META_KEY, &uploaded_at.as_millis())?;
// Clean up.
db.execute_batch("DELETE FROM itemsToUpload")?;
tx.commit()?;
Ok(())
}
pub(crate) fn update_frecencies(db: &PlacesDb, scope: &SqlInterruptScope) -> Result<()> {
let mut tx = db.begin_transaction()?;
let mut frecencies = Vec::with_capacity(MAX_FRECENCIES_TO_RECALCULATE_PER_CHUNK);
loop {
let sql = format!(
"SELECT place_id FROM moz_places_stale_frecencies
ORDER BY stale_at DESC
LIMIT {}",
MAX_FRECENCIES_TO_RECALCULATE_PER_CHUNK
);
let mut stmt = db.prepare_maybe_cached(&sql, true)?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
let place_id = row.get("place_id")?;
// Frecency recalculation runs several statements, so check to
// make sure we aren't interrupted before each calculation.
scope.err_if_interrupted()?;
let frecency =
calculate_frecency(db, &DEFAULT_FRECENCY_SETTINGS, place_id, Some(false))?;
frecencies.push((place_id, frecency));
}
if frecencies.is_empty() {
break;
}
// Update all frecencies in one fell swoop...
db.execute_batch(&format!(
"WITH frecencies(id, frecency) AS (
VALUES {}
)
UPDATE moz_places SET
frecency = (SELECT frecency FROM frecencies f
WHERE f.id = id)
WHERE id IN (SELECT f.id FROM frecencies f)",
sql_support::repeat_display(frecencies.len(), ",", |index, f| {
let (id, frecency) = frecencies[index];
write!(f, "({}, {})", id, frecency)
})
))?;
tx.maybe_commit()?;
scope.err_if_interrupted()?;
// ...And remove them from the stale table.
db.execute_batch(&format!(
"DELETE FROM moz_places_stale_frecencies
WHERE place_id IN ({})",
sql_support::repeat_display(frecencies.len(), ",", |index, f| {
let (id, _) = frecencies[index];
write!(f, "{}", id)
})
))?;
tx.maybe_commit()?;
scope.err_if_interrupted()?;
// If the query returned fewer URLs than the maximum, we're done.
// Otherwise, we might have more, so clear the ones we just
// recalculated and fetch the next chunk.
if frecencies.len() < MAX_FRECENCIES_TO_RECALCULATE_PER_CHUNK {
break;
}
frecencies.clear();
}
tx.commit()?;
Ok(())
}
// Short-lived struct that's constructed each sync
pub struct BookmarksSyncEngine {
db: Arc<SharedPlacesDb>,
// Pub so that it can be used by the PlacesApi methods. Once all syncing goes through the
// `SyncManager` we should be able to make this private.
pub(crate) scope: SqlInterruptScope,
}
impl BookmarksSyncEngine {
pub fn new(db: Arc<SharedPlacesDb>) -> Result<Self> {
Ok(Self {
scope: db.begin_interrupt_scope()?,
db,
})
}
}
impl SyncEngine for BookmarksSyncEngine {
#[inline]
fn collection_name(&self) -> CollectionName {
COLLECTION_NAME.into()
}
fn stage_incoming(
&self,
inbound: Vec<IncomingBso>,
telem: &mut telemetry::Engine,
) -> anyhow::Result<()> {
let conn = self.db.lock();
// Stage all incoming items.
let mut incoming_telemetry = telemetry::EngineIncoming::new();
stage_incoming(&conn, &self.scope, inbound, &mut incoming_telemetry)?;
telem.incoming(incoming_telemetry);
Ok(())
}
fn apply(
&self,
timestamp: ServerTimestamp,
telem: &mut telemetry::Engine,
) -> anyhow::Result<Vec<OutgoingBso>> {
let conn = self.db.lock();
// write the timestamp now, so if we are interrupted merging or
// creating outgoing changesets we don't need to re-apply the same
// records.
put_meta(&conn, LAST_SYNC_META_KEY, ×tamp.as_millis())?;
// Merge.
let mut merger = Merger::with_telemetry(&conn, &self.scope, timestamp, telem);
merger.merge()?;
Ok(fetch_outgoing_records(&conn, &self.scope)?)
}
fn set_uploaded(
&self,
new_timestamp: ServerTimestamp,
ids: Vec<SyncGuid>,
) -> anyhow::Result<()> {
let conn = self.db.lock();
push_synced_items(&conn, &self.scope, new_timestamp, ids)?;
Ok(update_frecencies(&conn, &self.scope)?)
}
fn sync_finished(&self) -> anyhow::Result<()> {
let conn = self.db.lock();
conn.pragma_update(None, "wal_checkpoint", "PASSIVE")?;
Ok(())
}
fn get_collection_request(
&self,
server_timestamp: ServerTimestamp,
) -> anyhow::Result<Option<CollectionRequest>> {
let conn = self.db.lock();
let since =
ServerTimestamp(get_meta::<i64>(&conn, LAST_SYNC_META_KEY)?.unwrap_or_default());
Ok(if since == server_timestamp {
None
} else {
Some(
CollectionRequest::new(self.collection_name())
.full()
.newer_than(since),
)
})
}
fn get_sync_assoc(&self) -> anyhow::Result<EngineSyncAssociation> {
let conn = self.db.lock();
let global = get_meta(&conn, GLOBAL_SYNCID_META_KEY)?;
let coll = get_meta(&conn, COLLECTION_SYNCID_META_KEY)?;
Ok(if let (Some(global), Some(coll)) = (global, coll) {
EngineSyncAssociation::Connected(CollSyncIds { global, coll })
} else {
EngineSyncAssociation::Disconnected
})
}
fn reset(&self, assoc: &EngineSyncAssociation) -> anyhow::Result<()> {
let conn = self.db.lock();
reset(&conn, assoc)?;
Ok(())
}
/// Erases all local items. Unlike `reset`, this keeps all synced items
/// until the next sync, when they will be replaced with tombstones. This
/// also preserves the sync ID and last sync time.
///
/// Conceptually, the next sync will merge an empty local tree, and a full
/// remote tree.
fn wipe(&self) -> anyhow::Result<()> {
let conn = self.db.lock();
let tx = conn.begin_transaction()?;
let sql = format!(
"INSERT INTO moz_bookmarks_deleted(guid, dateRemoved)
SELECT guid, now()
FROM moz_bookmarks
WHERE guid NOT IN {roots} AND
syncStatus = {sync_status};
UPDATE moz_bookmarks SET
syncChangeCounter = syncChangeCounter + 1
WHERE guid IN {roots};
DELETE FROM moz_bookmarks
WHERE guid NOT IN {roots};",
roots = RootsFragment(&[
BookmarkRootGuid::Root,
BookmarkRootGuid::Menu,
BookmarkRootGuid::Mobile,
BookmarkRootGuid::Toolbar,
BookmarkRootGuid::Unfiled
]),
sync_status = SyncStatus::Normal as u8
);
conn.execute_batch(&sql)?;
create_synced_bookmark_roots(&conn)?;
tx.commit()?;
Ok(())
}
}
#[derive(Default)]
struct Driver {
validation: RefCell<telemetry::Validation>,
}
impl dogear::Driver for Driver {
fn generate_new_guid(&self, _invalid_guid: &dogear::Guid) -> dogear::Result<dogear::Guid> {
Ok(SyncGuid::random().as_str().into())
}
fn record_telemetry_event(&self, event: TelemetryEvent) {
// Record validation telemetry for remote trees.
if let TelemetryEvent::FetchRemoteTree(stats) = event {
self.validation
.borrow_mut()
.problem("orphans", stats.problems.orphans)
.problem("misparentedRoots", stats.problems.misparented_roots)
.problem(
"multipleParents",
stats.problems.multiple_parents_by_children,
)
.problem("missingParents", stats.problems.missing_parent_guids)
.problem("nonFolderParents", stats.problems.non_folder_parent_guids)
.problem(
"parentChildDisagreements",
stats.problems.parent_child_disagreements,
)
.problem("missingChildren", stats.problems.missing_children);
}
}
}
// The "merger", which is just a thin wrapper for dogear.
pub(crate) struct Merger<'a> {
db: &'a PlacesDb,
scope: &'a SqlInterruptScope,
remote_time: ServerTimestamp,
local_time: Timestamp,
// Used for where the merger is not the one which should be managing the
// transaction, e.g. in the case of bookmarks import. The only impact this has
// is on the `apply()` function. Always false unless the caller explicitly
// turns it on, to avoid accidentally enabling unintentionally.
external_transaction: bool,
telem: Option<&'a mut telemetry::Engine>,
// Allows us to abort applying the result of the merge if the local tree
// changed since we fetched it.
global_change_tracker: GlobalChangeCounterTracker,
}
impl<'a> Merger<'a> {
#[cfg(test)]
pub(crate) fn new(
db: &'a PlacesDb,
scope: &'a SqlInterruptScope,
remote_time: ServerTimestamp,
) -> Self {
Self {
db,
scope,
remote_time,
local_time: Timestamp::now(),
external_transaction: false,
telem: None,
global_change_tracker: db.global_bookmark_change_tracker(),
}
}
pub(crate) fn with_telemetry(
db: &'a PlacesDb,
scope: &'a SqlInterruptScope,
remote_time: ServerTimestamp,
telem: &'a mut telemetry::Engine,
) -> Self {
Self {
db,
scope,
remote_time,
local_time: Timestamp::now(),
external_transaction: false,
telem: Some(telem),
global_change_tracker: db.global_bookmark_change_tracker(),
}
}
#[cfg(test)]
fn with_localtime(
db: &'a PlacesDb,
scope: &'a SqlInterruptScope,
remote_time: ServerTimestamp,
local_time: Timestamp,
) -> Self {
Self {
db,
scope,
remote_time,
local_time,
external_transaction: false,
telem: None,
global_change_tracker: db.global_bookmark_change_tracker(),
}
}
pub(crate) fn merge(&mut self) -> Result<()> {
use dogear::Store;
if !db_has_changes(self.db)? {
return Ok(());
}
// Merge and stage outgoing items via dogear.
let driver = Driver::default();
self.prepare()?;
let result = self.merge_with_driver(&driver, &MergeInterruptee(self.scope));
debug!("merge completed: {:?}", result);
// Record telemetry in all cases, even if the merge fails.
if let Some(ref mut telem) = self.telem {
telem.validation(driver.validation.into_inner());
}
result
}
/// Prepares synced bookmarks for merging.
fn prepare(&self) -> Result<()> {
// Sync and Fennec associate keywords with bookmarks, and don't sync
// POST data; Rust Places associates them with URLs, and also doesn't
// support POST data; Desktop associates keywords with (URL, POST data)
// pairs, and multiple bookmarks may have the same URL.
//
// When a keyword changes, clients should reupload all bookmarks with
// bookmarks that have different keywords for the same URL, or the same
// keyword for different URLs, for reupload.
self.scope.err_if_interrupted()?;
debug!("Flagging bookmarks with mismatched keywords for reupload");
let sql = format!(
"UPDATE moz_bookmarks_synced SET
validity = {reupload}
WHERE validity = {valid} AND (
placeId IN (
/* Same URL, different keywords. `COUNT` ignores NULLs, so
we need to count them separately. This handles cases where
a keyword was removed from one, but not all bookmarks with
the same URL. */
SELECT placeId FROM moz_bookmarks_synced
GROUP BY placeId
HAVING COUNT(DISTINCT keyword) +
COUNT(DISTINCT CASE WHEN keyword IS NULL
THEN 1 END) > 1
) OR keyword IN (
/* Different URLs, same keyword. Bookmarks with keywords but
without URLs are already invalid, so we don't need to handle
NULLs here. */
SELECT keyword FROM moz_bookmarks_synced
WHERE keyword NOT NULL
GROUP BY keyword
HAVING COUNT(DISTINCT placeId) > 1
)
)",
reupload = SyncedBookmarkValidity::Reupload as u8,
valid = SyncedBookmarkValidity::Valid as u8,
);
self.db.execute_batch(&sql)?;
// Like keywords, Sync associates tags with bookmarks, but Places
// associates them with URLs. This means multiple bookmarks with the
// same URL should have the same tags. In practice, different tags for
// bookmarks with the same URL are some of the most common validation
// errors we see.
//
// Unlike keywords, the relationship between URLs and tags in many-many:
// multiple URLs can have the same tag, and a URL can have multiple
// tags. So, to find mismatches, we need to compare the tags for each
// URL with the tags for each item.
//
// We could fetch both lists of tags, sort them, and then compare them.
// But there's a trick here: we're only interested in whether the tags
// _match_, not the tags themselves. So we sum the tag IDs!
//
// This has two advantages: we don't have to sort IDs, since addition is
// commutative, and we can compare two integers much more efficiently
// than two string lists! If a bookmark has mismatched tags, the sum of
// its tag IDs in `tagsByItemId` won't match the sum in `tagsByPlaceId`,
// and we'll flag the item for reupload.
self.scope.err_if_interrupted()?;
debug!("Flagging bookmarks with mismatched tags for reupload");
let sql = format!(
"WITH
tagsByPlaceId(placeId, tagIds) AS (
/* For multiple bookmarks with the same URL, each group will
have one tag per bookmark. So, if bookmarks A1, A2, and A3
have the same URL A with tag T, T will be in the group three
times. But we only want to count each tag once per URL, so
we use `SUM(DISTINCT)`. */
SELECT v.placeId, SUM(DISTINCT t.tagId)
FROM moz_bookmarks_synced v
JOIN moz_bookmarks_synced_tag_relation t ON t.itemId = v.id
WHERE v.placeId NOT NULL
GROUP BY v.placeId
),
tagsByItemId(itemId, tagIds) AS (
/* But here, we can use a plain `SUM`, since we're grouping by
item ID, and an item can't have duplicate tags thanks to the
primary key on the relation table. */
SELECT t.itemId, SUM(t.tagId)
FROM moz_bookmarks_synced_tag_relation t
GROUP BY t.itemId
)
UPDATE moz_bookmarks_synced SET
validity = {reupload}
WHERE validity = {valid} AND id IN (
SELECT v.id FROM moz_bookmarks_synced v
JOIN tagsByPlaceId u ON v.placeId = u.placeId
/* This left join is important: if A1 has tags and A2 doesn't,
we want to flag A2 for reupload. */
LEFT JOIN tagsByItemId t ON t.itemId = v.id
/* Unlike `<>`, `IS NOT` compares NULLs. */
WHERE t.tagIds IS NOT u.tagIds
)",
reupload = SyncedBookmarkValidity::Reupload as u8,
valid = SyncedBookmarkValidity::Valid as u8,
);
self.db.execute_batch(&sql)?;
Ok(())
}
/// Creates a local tree item from a row in the `localItems` CTE.
fn local_row_to_item(&self, row: &Row<'_>) -> Result<(Item, Option<Content>)> {
let guid = row.get::<_, SyncGuid>("guid")?;
let url_href = row.get::<_, Option<String>>("url")?;
let kind = match row.get::<_, BookmarkType>("type")? {
BookmarkType::Bookmark => match url_href.as_ref() {
Some(u) if u.starts_with("place:") => SyncedBookmarkKind::Query,
_ => SyncedBookmarkKind::Bookmark,
},
BookmarkType::Folder => SyncedBookmarkKind::Folder,
BookmarkType::Separator => SyncedBookmarkKind::Separator,
};
let mut item = Item::new(guid.as_str().into(), kind.into());
// Note that this doesn't account for local clock skew.
let age = self
.local_time
.duration_since(row.get::<_, Timestamp>("localModified")?)
.unwrap_or_default();
item.age = age.as_secs() as i64 * 1000 + i64::from(age.subsec_millis());
item.needs_merge = row.get::<_, u32>("syncChangeCounter")? > 0;
let content = if item.guid == dogear::ROOT_GUID {
None
} else {
match row.get::<_, SyncStatus>("syncStatus")? {
SyncStatus::Normal => None,
_ => match kind {
SyncedBookmarkKind::Bookmark | SyncedBookmarkKind::Query => {
let title = row.get::<_, String>("title")?;
url_href.map(|url_href| Content::Bookmark { title, url_href })
}
SyncedBookmarkKind::Folder | SyncedBookmarkKind::Livemark => {
let title = row.get::<_, String>("title")?;
Some(Content::Folder { title })
}
SyncedBookmarkKind::Separator => Some(Content::Separator),
},
}
};
Ok((item, content))
}
/// Creates a remote tree item from a row in `moz_bookmarks_synced`.
fn remote_row_to_item(&self, row: &Row<'_>) -> Result<(Item, Option<Content>)> {
let guid = row.get::<_, SyncGuid>("guid")?;
let kind = SyncedBookmarkKind::from_u8(row.get("kind")?)?;
let mut item = Item::new(guid.as_str().into(), kind.into());
// note that serverModified in this table is an int with ms, which isn't
// the format of a ServerTimestamp - so we convert it into a number
// of seconds before creating a ServerTimestamp and doing duration_since.
let age = self
.remote_time
.duration_since(ServerTimestamp(row.get::<_, i64>("serverModified")?))
.unwrap_or_default();
item.age = age.as_secs() as i64 * 1000 + i64::from(age.subsec_millis());
item.needs_merge = row.get("needsMerge")?;
item.validity = SyncedBookmarkValidity::from_u8(row.get("validity")?)?.into();
let content = if item.guid == dogear::ROOT_GUID || !item.needs_merge {
None
} else {
match kind {
SyncedBookmarkKind::Bookmark | SyncedBookmarkKind::Query => {
let title = row.get::<_, String>("title")?;
let url_href = row.get::<_, Option<String>>("url")?;
url_href.map(|url_href| Content::Bookmark { title, url_href })
}
SyncedBookmarkKind::Folder | SyncedBookmarkKind::Livemark => {
let title = row.get::<_, String>("title")?;
Some(Content::Folder { title })
}
SyncedBookmarkKind::Separator => Some(Content::Separator),
}
};
Ok((item, content))
}
}
impl dogear::Store for Merger<'_> {
type Ok = ();
type Error = Error;
/// Builds a fully rooted, consistent tree from all local items and
/// tombstones.
fn fetch_local_tree(&self) -> Result<Tree> {
let mut stmt = self.db.prepare(&format!(
"SELECT guid, type, syncChangeCounter, syncStatus,
lastModified AS localModified,
NULL AS url
FROM moz_bookmarks
WHERE guid = '{root_guid}'",
root_guid = BookmarkRootGuid::Root.as_guid().as_str(),
))?;
let mut results = stmt.query([])?;
let mut builder = match results.next()? {
Some(row) => {
let (item, _) = self.local_row_to_item(row)?;
Tree::with_root(item)
}
None => return Err(Error::Corruption(Corruption::InvalidLocalRoots)),
};
// Add items and contents to the builder, keeping track of their
// structure in a separate map. We can't call `p.by_structure(...)`
// after adding the item, because this query might return rows for
// children before their parents. This approach also lets us scan
// `moz_bookmarks` once, using the index on `(b.parent, b.position)`
// to avoid a temp B-tree for the `ORDER BY`.
let mut child_guids_by_parent_guid: HashMap<SyncGuid, Vec<dogear::Guid>> = HashMap::new();
let mut stmt = self.db.prepare(&format!(
"SELECT b.guid, p.guid AS parentGuid, b.type, b.syncChangeCounter,
b.syncStatus, b.lastModified AS localModified,
IFNULL(b.title, '') AS title,
{url_fragment} AS url
FROM moz_bookmarks b
JOIN moz_bookmarks p ON p.id = b.parent
WHERE b.guid <> '{root_guid}'
ORDER BY b.parent, b.position",
url_fragment = UrlOrPlaceIdFragment::PlaceId("b.fk"),
root_guid = BookmarkRootGuid::Root.as_guid().as_str(),
))?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
self.scope.err_if_interrupted()?;
let (item, content) = self.local_row_to_item(row)?;
let parent_guid = row.get::<_, SyncGuid>("parentGuid")?;
child_guids_by_parent_guid
.entry(parent_guid)
.or_default()
.push(item.guid.clone());
let mut p = builder.item(item)?;
if let Some(content) = content {
p.content(content);
}
}
// At this point, we've added entries for all items to the tree, so
// we can add their structure info.
for (parent_guid, child_guids) in &child_guids_by_parent_guid {
for child_guid in child_guids {
self.scope.err_if_interrupted()?;
builder
.parent_for(child_guid)
.by_structure(&parent_guid.as_str().into())?;
}
}
// Note tombstones for locally deleted items.
let mut stmt = self.db.prepare("SELECT guid FROM moz_bookmarks_deleted")?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
self.scope.err_if_interrupted()?;
let guid = row.get::<_, SyncGuid>("guid")?;
builder.deletion(guid.as_str().into());
}
let tree = Tree::try_from(builder)?;
Ok(tree)
}
/// Builds a fully rooted tree from all synced items and tombstones.
fn fetch_remote_tree(&self) -> Result<Tree> {
// Unlike the local tree, items and structure are stored separately, so
// we use three separate statements to fetch the root, its descendants,
// and their structure.
let sql = format!(
"SELECT guid, serverModified, kind, needsMerge, validity
FROM moz_bookmarks_synced
WHERE NOT isDeleted AND
guid = '{root_guid}'",
root_guid = BookmarkRootGuid::Root.as_guid().as_str()
);
let mut builder = self
.db
.try_query_row(
&sql,
[],
|row| -> Result<_> {
let (root, _) = self.remote_row_to_item(row)?;
Ok(Tree::with_root(root))
},
false,
)?
.ok_or(Error::Corruption(Corruption::InvalidSyncedRoots))?;
builder.reparent_orphans_to(&dogear::UNFILED_GUID);
let sql = format!(
"SELECT v.guid, v.parentGuid, v.serverModified, v.kind,
IFNULL(v.title, '') AS title, v.needsMerge, v.validity,
v.isDeleted, {url_fragment} AS url
FROM moz_bookmarks_synced v
WHERE v.guid <> '{root_guid}'
ORDER BY v.guid",
url_fragment = UrlOrPlaceIdFragment::PlaceId("v.placeId"),
root_guid = BookmarkRootGuid::Root.as_guid().as_str()
);
let mut stmt = self.db.prepare(&sql)?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
self.scope.err_if_interrupted()?;
let is_deleted = row.get::<_, bool>("isDeleted")?;
if is_deleted {
let needs_merge = row.get::<_, bool>("needsMerge")?;
if !needs_merge {
// Ignore already-merged tombstones. These aren't persisted
// locally, so merging them is a no-op.
continue;
}
let guid = row.get::<_, SyncGuid>("guid")?;
builder.deletion(guid.as_str().into());
} else {
let (item, content) = self.remote_row_to_item(row)?;
let mut p = builder.item(item)?;
if let Some(content) = content {
p.content(content);
}
if let Some(parent_guid) = row.get::<_, Option<SyncGuid>>("parentGuid")? {
p.by_parent_guid(parent_guid.as_str().into())?;
}
}
}
let sql = format!(
"SELECT guid, parentGuid FROM moz_bookmarks_synced_structure
WHERE guid <> '{root_guid}'
ORDER BY parentGuid, position",
root_guid = BookmarkRootGuid::Root.as_guid().as_str()
);
let mut stmt = self.db.prepare(&sql)?;
let mut results = stmt.query([])?;
while let Some(row) = results.next()? {
self.scope.err_if_interrupted()?;
let guid = row.get::<_, SyncGuid>("guid")?;
let parent_guid = row.get::<_, SyncGuid>("parentGuid")?;
builder
.parent_for(&guid.as_str().into())
.by_children(&parent_guid.as_str().into())?;
}
let tree = Tree::try_from(builder)?;
Ok(tree)
}
fn apply(&mut self, root: MergedRoot<'_>) -> Result<()> {
let ops = root.completion_ops_with_signal(&MergeInterruptee(self.scope))?;
if ops.is_empty() {
// If we don't have any items to apply, upload, or delete,
// no need to open a transaction at all.
return Ok(());
}
let tx = if !self.external_transaction {
Some(self.db.begin_transaction()?)
} else {
None
};
// If the local tree has changed since we started the merge, we abort
// in the expectation it will succeed next time.
if self.global_change_tracker.changed() {
info!("Aborting update of local items as local tree changed while merging");
if let Some(tx) = tx {
tx.rollback()?;
}
return Ok(());
}
debug!("Updating local items in Places");
update_local_items_in_places(self.db, self.scope, self.local_time, &ops)?;
debug!(
"Staging {} items and {} tombstones to upload",
ops.upload_items.len(),
ops.upload_tombstones.len()
);
stage_items_to_upload(
self.db,
self.scope,
&ops.upload_items,
&ops.upload_tombstones,
)?;
self.db.execute_batch("DELETE FROM itemsToApply;")?;
if let Some(tx) = tx {
tx.commit()?;
}
Ok(())
}
}
/// A helper that formats an optional value so that it can be included in a SQL
/// statement. `None` values become SQL `NULL`s.
struct NullableFragment<T>(Option<T>);
impl<T> fmt::Display for NullableFragment<T>
where
T: fmt::Display,
{
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match &self.0 {
Some(v) => v.fmt(f),
None => write!(f, "NULL"),
}
}
}
/// A helper that interpolates a SQL `CASE` expression for converting a synced
/// item kind to a local item type. The expression evaluates to `NULL` if the
/// kind is unknown.
struct ItemTypeFragment(&'static str);
impl fmt::Display for ItemTypeFragment {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(
f,
"(CASE WHEN {col} IN ({bookmark_kind}, {query_kind})
THEN {bookmark_type}
WHEN {col} IN ({folder_kind}, {livemark_kind})
THEN {folder_type}
WHEN {col} = {separator_kind}
THEN {separator_type}
END)",
col = self.0,
bookmark_kind = SyncedBookmarkKind::Bookmark as u8,
query_kind = SyncedBookmarkKind::Query as u8,
bookmark_type = BookmarkType::Bookmark as u8,
folder_kind = SyncedBookmarkKind::Folder as u8,
livemark_kind = SyncedBookmarkKind::Livemark as u8,
folder_type = BookmarkType::Folder as u8,
separator_kind = SyncedBookmarkKind::Separator as u8,
separator_type = BookmarkType::Separator as u8,
)
}
}
/// Formats a `SELECT` statement for staging local items in the `itemsToUpload`
/// table.
struct UploadItemsFragment(&'static str);
impl fmt::Display for UploadItemsFragment {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(
f,
"SELECT {alias}.id, {alias}.guid, {alias}.syncChangeCounter,
p.guid AS parentGuid, p.title AS parentTitle,
{alias}.dateAdded, {kind_fragment} AS kind,
{alias}.title, h.id AS placeId, h.url,
(SELECT k.keyword FROM moz_keywords k
WHERE k.place_id = h.id) AS keyword,
{alias}.position
FROM moz_bookmarks {alias}
JOIN moz_bookmarks p ON p.id = {alias}.parent
LEFT JOIN moz_places h ON h.id = {alias}.fk",
alias = self.0,
kind_fragment = item_kind_fragment(self.0, "type", UrlOrPlaceIdFragment::Url("h.url")),
)
}
}
/// A helper that interpolates a named SQL common table expression (CTE) for
/// local items. The CTE may be included in a `WITH RECURSIVE` clause.
struct LocalItemsFragment<'a>(&'a str);
impl fmt::Display for LocalItemsFragment<'_> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(
f,
"{name}(id, guid, parentId, parentGuid, position, type, title, parentTitle,
placeId, dateAdded, lastModified, syncChangeCounter, level) AS (
SELECT b.id, b.guid, 0, NULL, b.position, b.type, b.title, NULL,
b.fk, b.dateAdded, b.lastModified, b.syncChangeCounter, 0
FROM moz_bookmarks b
WHERE b.guid = '{root_guid}'
UNION ALL
SELECT b.id, b.guid, s.id, s.guid, b.position, b.type, b.title, s.title,
b.fk, b.dateAdded, b.lastModified, b.syncChangeCounter, s.level + 1
FROM moz_bookmarks b
JOIN {name} s ON s.id = b.parent)",
name = self.0,
root_guid = BookmarkRootGuid::Root.as_guid().as_str()
)
}
}
fn item_kind_fragment(
table_name: &'static str,
type_column_name: &'static str,
url_or_place_id_fragment: UrlOrPlaceIdFragment,
) -> ItemKindFragment {
ItemKindFragment {
table_name,
type_column_name,
url_or_place_id_fragment,
}
}
/// A helper that interpolates a SQL `CASE` expression for converting a local
/// item type to a synced item kind. The expression evaluates to `NULL` if the
/// type is unknown.
struct ItemKindFragment {
/// The name of the Places bookmarks table.
table_name: &'static str,
/// The name of the column containing the Places item type.
type_column_name: &'static str,
/// The column containing the item's URL or Place ID.
url_or_place_id_fragment: UrlOrPlaceIdFragment,
}
impl fmt::Display for ItemKindFragment {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
write!(
f,
"(CASE {table_name}.{type_column_name}
WHEN {bookmark_type} THEN (
CASE substr({url}, 1, 6)
/* Queries are bookmarks with a 'place:' URL scheme. */
WHEN 'place:' THEN {query_kind}
ELSE {bookmark_kind}
END
)
WHEN {folder_type} THEN {folder_kind}
WHEN {separator_type} THEN {separator_kind}
END)",
table_name = self.table_name,
type_column_name = self.type_column_name,
bookmark_type = BookmarkType::Bookmark as u8,
url = self.url_or_place_id_fragment,
query_kind = SyncedBookmarkKind::Query as u8,
bookmark_kind = SyncedBookmarkKind::Bookmark as u8,
folder_type = BookmarkType::Folder as u8,
folder_kind = SyncedBookmarkKind::Folder as u8,
separator_type = BookmarkType::Separator as u8,
separator_kind = SyncedBookmarkKind::Separator as u8,
)
}
}
/// A helper that interpolates a SQL expression for querying a local item's
/// URL. Note that the `&'static str` for each variant specifies the _name of
/// the column_ containing the URL or ID, not the URL or ID itself.
enum UrlOrPlaceIdFragment {
/// The name of the column containing the URL. This avoids a subquery if
/// a column for the URL already exists in the query.
Url(&'static str),
/// The name of the column containing the Place ID. This writes out a
/// subquery to look up the URL.
PlaceId(&'static str),
}
impl fmt::Display for UrlOrPlaceIdFragment {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
match self {
UrlOrPlaceIdFragment::Url(s) => write!(f, "{}", s),
UrlOrPlaceIdFragment::PlaceId(s) => {
write!(f, "(SELECT h.url FROM moz_places h WHERE h.id = {})", s)
}
}
}
}
/// A helper that interpolates a SQL list containing the given bookmark
/// root GUIDs.
struct RootsFragment<'a>(&'a [BookmarkRootGuid]);
impl fmt::Display for RootsFragment<'_> {
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
f.write_str("(")?;
for (i, guid) in self.0.iter().enumerate() {
if i != 0 {
f.write_str(",")?;
}
write!(f, "'{}'", guid.as_str())?;
}
f.write_str(")")
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::api::places_api::{test::new_mem_api, ConnectionType, PlacesApi};
use crate::bookmark_sync::tests::SyncedBookmarkItem;
use crate::db::PlacesDb;
use crate::storage::{
bookmarks::{
get_raw_bookmark, insert_bookmark, update_bookmark, BookmarkPosition,
InsertableBookmark, UpdatableBookmark, USER_CONTENT_ROOTS,
},
history::frecency_stale_at,
tags,
};
use crate::tests::{
assert_json_tree as assert_local_json_tree, insert_json_tree as insert_local_json_tree,
};
use dogear::{Store as DogearStore, Validity};
use rusqlite::{Error as RusqlError, ErrorCode};
use serde_json::{json, Value};
use std::{
borrow::Cow,
time::{Duration, SystemTime},
};
use sync15::bso::{IncomingBso, IncomingKind};
use sync15::engine::CollSyncIds;
use sync_guid::Guid;
use url::Url;
// A helper type to simplify writing table-driven tests with synced items.
struct ExpectedSyncedItem<'a>(SyncGuid, Cow<'a, SyncedBookmarkItem>);
impl<'a> ExpectedSyncedItem<'a> {
fn new(
guid: impl Into<SyncGuid>,
expected: &'a SyncedBookmarkItem,
) -> ExpectedSyncedItem<'a> {
ExpectedSyncedItem(guid.into(), Cow::Borrowed(expected))
}
fn with_properties(
guid: impl Into<SyncGuid>,
expected: &'a SyncedBookmarkItem,
f: impl FnOnce(&mut SyncedBookmarkItem) -> &mut SyncedBookmarkItem + 'static,
) -> ExpectedSyncedItem<'a> {
let mut expected = expected.clone();
f(&mut expected);
ExpectedSyncedItem(guid.into(), Cow::Owned(expected))
}
fn check(&self, conn: &PlacesDb) -> Result<()> {
let actual =
SyncedBookmarkItem::get(conn, &self.0)?.expect("Expected synced item should exist");
assert_eq!(&actual, &*self.1);
Ok(())
}
}
fn create_sync_engine(api: &PlacesApi) -> BookmarksSyncEngine {
BookmarksSyncEngine::new(api.get_sync_connection().unwrap()).unwrap()
}
fn engine_apply_incoming(
engine: &BookmarksSyncEngine,
incoming: Vec<IncomingBso>,
) -> Vec<OutgoingBso> {
let mut telem = telemetry::Engine::new(engine.collection_name());
engine
.stage_incoming(incoming, &mut telem)
.expect("Should stage incoming");
engine
.apply(ServerTimestamp(0), &mut telem)
.expect("Should apply")
}
// Applies the incoming records, and also "finishes" the sync by pretending
// we uploaded the outgoing items and marks them as uploaded.
// Returns the GUIDs of the outgoing items.
fn apply_incoming(
api: &PlacesApi,
remote_time: ServerTimestamp,
records_json: Value,
) -> Vec<Guid> {
// suck records into the engine.
let engine = create_sync_engine(api);
let incoming = match records_json {
Value::Array(records) => records
.into_iter()
.map(|record| IncomingBso::from_test_content_ts(record, remote_time))
.collect(),
Value::Object(_) => {
vec![IncomingBso::from_test_content_ts(records_json, remote_time)]
}
_ => panic!("unexpected json value"),
};
engine_apply_incoming(&engine, incoming);
let sync_db = api.get_sync_connection().unwrap();
let syncer = sync_db.lock();
let mut stmt = syncer
.prepare("SELECT guid FROM itemsToUpload")
.expect("Should prepare statement to fetch uploaded GUIDs");
let uploaded_guids: Vec<Guid> = stmt
.query_and_then([], |row| -> rusqlite::Result<_> { row.get::<_, Guid>(0) })
.expect("Should fetch uploaded GUIDs")
.map(std::result::Result::unwrap)
.collect();
push_synced_items(&syncer, &engine.scope, remote_time, uploaded_guids.clone())
.expect("Should push synced changes back to the engine");
uploaded_guids
}
fn assert_incoming_creates_local_tree(
api: &PlacesApi,
records_json: Value,
local_folder: &SyncGuid,
local_tree: Value,
) {
apply_incoming(api, ServerTimestamp(0), records_json);
assert_local_json_tree(
&api.get_sync_connection().unwrap().lock(),
local_folder,
local_tree,
);
}
#[test]
fn test_fetch_remote_tree() -> Result<()> {
let records = vec![
json!({
"id": "qqVTRWhLBOu3",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled Bookmarks",
"dateAdded": 1_381_542_355_843u64,
"title": "The title",
"tags": [],
}),
json!({
"id": "unfiled",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "Unfiled Bookmarks",
"children": ["qqVTRWhLBOu3"],
"tags": [],
}),
];
let api = new_mem_api();
let db = api.get_sync_connection().unwrap();
let conn = db.lock();
// suck records into the database.
let interrupt_scope = conn.begin_interrupt_scope()?;
let incoming = records
.into_iter()
.map(IncomingBso::from_test_content)
.collect();
stage_incoming(
&conn,
&interrupt_scope,
incoming,
&mut telemetry::EngineIncoming::new(),
)
.expect("Should apply incoming and stage outgoing records");
let merger = Merger::new(&conn, &interrupt_scope, ServerTimestamp(0));
let tree = merger.fetch_remote_tree()?;
// should be each user root, plus the real root, plus the bookmark we added.
assert_eq!(tree.guids().count(), USER_CONTENT_ROOTS.len() + 2);
let node = tree
.node_for_guid(&"qqVTRWhLBOu3".into())
.expect("should exist");
assert!(node.needs_merge);
assert_eq!(node.validity, Validity::Valid);
assert_eq!(node.level(), 2);
assert!(node.is_syncable());
let node = tree
.node_for_guid(&BookmarkRootGuid::Unfiled.as_guid().as_str().into())
.expect("should exist");
assert!(node.needs_merge);
assert_eq!(node.validity, Validity::Valid);
assert_eq!(node.level(), 1);
assert!(node.is_syncable());
let node = tree
.node_for_guid(&BookmarkRootGuid::Menu.as_guid().as_str().into())
.expect("should exist");
assert!(!node.needs_merge);
assert_eq!(node.validity, Validity::Valid);
assert_eq!(node.level(), 1);
assert!(node.is_syncable());
let node = tree
.node_for_guid(&BookmarkRootGuid::Root.as_guid().as_str().into())
.expect("should exist");
assert_eq!(node.validity, Validity::Valid);
assert_eq!(node.level(), 0);
assert!(!node.is_syncable());
// We should have changes.
assert!(db_has_changes(&conn).unwrap());
Ok(())
}
#[test]
fn test_fetch_local_tree() -> Result<()> {
let now = SystemTime::now();
let previously_ts: Timestamp = (now - Duration::new(10, 0)).into();
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
let sync_db = api.get_sync_connection().unwrap();
let syncer = sync_db.lock();
writer
.execute("UPDATE moz_bookmarks SET syncChangeCounter = 0", [])
.expect("should work");
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [
{
"guid": "bookmark1___",
"title": "the bookmark",
"last_modified": previously_ts,
"date_added": previously_ts,
},
]
}),
);
let interrupt_scope = syncer.begin_interrupt_scope()?;
let merger =
Merger::with_localtime(&syncer, &interrupt_scope, ServerTimestamp(0), now.into());
let tree = merger.fetch_local_tree()?;
// should be each user root, plus the real root, plus the bookmark we added.
assert_eq!(tree.guids().count(), USER_CONTENT_ROOTS.len() + 2);
let node = tree
.node_for_guid(&"bookmark1___".into())
.expect("should exist");
assert!(node.needs_merge);
assert_eq!(node.level(), 2);
assert!(node.is_syncable());
assert_eq!(node.age, 10000);
let node = tree
.node_for_guid(&BookmarkRootGuid::Unfiled.as_guid().as_str().into())
.expect("should exist");
assert!(node.needs_merge);
assert_eq!(node.level(), 1);
assert!(node.is_syncable());
let node = tree
.node_for_guid(&BookmarkRootGuid::Menu.as_guid().as_str().into())
.expect("should exist");
assert!(!node.needs_merge);
assert_eq!(node.level(), 1);
assert!(node.is_syncable());
let node = tree
.node_for_guid(&BookmarkRootGuid::Root.as_guid().as_str().into())
.expect("should exist");
assert!(!node.needs_merge);
assert_eq!(node.level(), 0);
assert!(!node.is_syncable());
// hard to know the exact age of the root, but we know the max.
let max_dur = SystemTime::now().duration_since(now).unwrap();
let max_age = max_dur.as_secs() as i64 * 1000 + i64::from(max_dur.subsec_millis());
assert!(node.age <= max_age);
// We should have changes.
assert!(db_has_changes(&syncer).unwrap());
Ok(())
}
#[test]
fn test_apply_bookmark() {
let api = new_mem_api();
assert_incoming_creates_local_tree(
&api,
json!([{
"id": "bookmark1___",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled Bookmarks",
"dateAdded": 1_381_542_355_843u64,
"title": "Some bookmark",
},
{
"id": "unfiled",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Unfiled",
"children": ["bookmark1___"],
}]),
&BookmarkRootGuid::Unfiled.as_guid(),
);
let reader = api
.open_connection(ConnectionType::ReadOnly)
.expect("Should open read-only connection");
assert!(
.expect("Should check stale frecency")
.is_some(),
"Should mark frecency for bookmark URL as stale"
);
let writer = api
.open_connection(ConnectionType::ReadWrite)
.expect("Should open read-write connection");
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [
{
"guid": "bookmark2___",
"title": "2",
}
],
}),
);
assert_incoming_creates_local_tree(
&api,
json!([{
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "menu",
"children": ["bookmark2___"],
}, {
"id": "bookmark2___",
"type": "bookmark",
"parentid": "menu",
"parentName": "menu",
"dateAdded": 1_381_542_355_843u64,
"title": "2",
}]),
&BookmarkRootGuid::Menu.as_guid(),
);
assert!(
.expect("Should check stale frecency for old URL")
.is_some(),
"Should mark frecency for old URL as stale"
);
assert!(
.expect("Should check stale frecency for new URL")
.is_some(),
"Should mark frecency for new URL as stale"
);
let sync_db = api.get_sync_connection().unwrap();
let syncer = sync_db.lock();
let interrupt_scope = syncer.begin_interrupt_scope().unwrap();
update_frecencies(&syncer, &interrupt_scope).expect("Should update frecencies");
assert!(
.expect("Should check stale frecency")
.is_none(),
"Should recalculate frecency for first bookmark"
);
assert!(
.expect("Should check stale frecency for old URL")
.is_none(),
"Should recalculate frecency for old URL"
);
assert!(
.expect("Should check stale frecency for new URL")
.is_none(),
"Should recalculate frecency for new URL"
);
}
#[test]
fn test_apply_complex_bookmark_tags() -> Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
// Insert two local bookmarks with the same URL A (so they'll have
// identical tags) and a third with a different URL B, but one same
// tag as A.
let local_bookmarks = vec![
InsertableBookmark {
parent_guid: BookmarkRootGuid::Unfiled.as_guid(),
position: BookmarkPosition::Append,
date_added: None,
last_modified: None,
guid: Some("bookmarkAAA1".into()),
title: Some("A1".into()),
}
.into(),
InsertableBookmark {
parent_guid: BookmarkRootGuid::Menu.as_guid(),
position: BookmarkPosition::Append,
date_added: None,
last_modified: None,
guid: Some("bookmarkAAA2".into()),
title: Some("A2".into()),
}
.into(),
InsertableBookmark {
parent_guid: BookmarkRootGuid::Unfiled.as_guid(),
position: BookmarkPosition::Append,
date_added: None,
last_modified: None,
guid: Some("bookmarkBBBB".into()),
title: Some("B".into()),
}
.into(),
];
let local_tags = &[
(
// Local duplicate tags should be ignored.
vec!["two", "three", "three", "four"],
),
];
for bm in local_bookmarks.into_iter() {
insert_bookmark(&writer, bm)?;
}
for (url, tags) in local_tags {
let url = Url::parse(url)?;
for t in tags.iter() {
tags::tag_url(&writer, &url, t)?;
}
}
// Now for some fun server data. Only B, C, and F2 have problems;
// D and E are fine, and shouldn't be reuploaded.
let remote_records = json!([{
// Change B's tags on the server, and duplicate `two` for good
// measure. We should reupload B with only one `two` tag.
"id": "bookmarkBBBB",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"dateAdded": 1_381_542_355_843u64,
"title": "B",
"tags": ["two", "two", "three", "eight"],
}, {
// C is an example of bad data on the server: bookmarks with the
// same URL should have the same tags, but C1/C2 have different tags
// than C3. We should reupload all of them.
"id": "bookmarkCCC1",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"dateAdded": 1_381_542_355_843u64,
"title": "C1",
"tags": ["four", "five", "six"],
}, {
"id": "bookmarkCCC2",
"type": "bookmark",
"parentid": "menu",
"parentName": "Menu",
"dateAdded": 1_381_542_355_843u64,
"title": "C2",
"tags": ["four", "five", "six"],
}, {
"id": "bookmarkCCC3",
"type": "bookmark",
"parentid": "menu",
"parentName": "Menu",
"dateAdded": 1_381_542_355_843u64,
"title": "C3",
"tags": ["six", "six", "seven"],
}, {
// D has the same tags as C1/2, but a different URL. This is
// perfectly fine, since URLs and tags are many-many! D also
// isn't duplicated, so it'll be filtered out by the
// `HAVING COUNT(*) > 1` clause.
"id": "bookmarkDDDD",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"dateAdded": 1_381_542_355_843u64,
"title": "D",
"tags": ["four", "five", "six"],
}, {
// E1 and E2 have the same URLs and the same tags, so we shouldn't
// reupload either.
"id": "bookmarkEEE1",
"type": "bookmark",
"parentid": "toolbar",
"parentName": "Toolbar",
"dateAdded": 1_381_542_355_843u64,
"title": "E1",
"tags": ["nine", "ten", "eleven"],
}, {
"id": "bookmarkEEE2",
"type": "bookmark",
"parentid": "mobile",
"parentName": "Mobile",
"dateAdded": 1_381_542_355_843u64,
"title": "E2",
"tags": ["nine", "ten", "eleven"],
}, {
// F1 and F2 have mismatched tags, but with a twist: F2 doesn't
// have _any_ tags! We should only reupload F2.
"id": "bookmarkFFF1",
"type": "bookmark",
"parentid": "toolbar",
"parentName": "Toolbar",
"dateAdded": 1_381_542_355_843u64,
"title": "F1",
"tags": ["twelve"],
}, {
"id": "bookmarkFFF2",
"type": "bookmark",
"parentid": "mobile",
"parentName": "Mobile",
"dateAdded": 1_381_542_355_843u64,
"title": "F2",
}, {
"id": "unfiled",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Unfiled",
"children": ["bookmarkBBBB", "bookmarkCCC1", "bookmarkDDDD"],
}, {
"id": "menu",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Menu",
"children": ["bookmarkCCC2", "bookmarkCCC3"],
}, {
"id": "toolbar",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Toolbar",
"children": ["bookmarkEEE1", "bookmarkFFF1"],
}, {
"id": "mobile",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Mobile",
"children": ["bookmarkEEE2", "bookmarkFFF2"],
}]);
// Boilerplate to apply incoming records, since we want to check
// outgoing record contents.
let engine = create_sync_engine(&api);
let incoming = if let Value::Array(records) = remote_records {
records
.into_iter()
.map(IncomingBso::from_test_content)
.collect()
} else {
unreachable!("JSON records must be an array");
};
let mut outgoing = engine_apply_incoming(&engine, incoming);
outgoing.sort_by(|a, b| a.envelope.id.cmp(&b.envelope.id));
// Verify that we applied all incoming records correctly.
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Root.as_guid(),
json!({
"guid": &BookmarkRootGuid::Root.as_guid(),
"children": [{
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
"guid": "bookmarkCCC2",
"title": "C2",
}, {
"guid": "bookmarkCCC3",
"title": "C3",
}, {
"guid": "bookmarkAAA2",
"title": "A2",
}],
}, {
"guid": &BookmarkRootGuid::Toolbar.as_guid(),
"children": [{
"guid": "bookmarkEEE1",
"title": "E1",
}, {
"guid": "bookmarkFFF1",
"title": "F1",
}],
}, {
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [{
"guid": "bookmarkBBBB",
"title": "B",
}, {
"guid": "bookmarkCCC1",
"title": "C1",
}, {
"guid": "bookmarkDDDD",
"title": "D",
}, {
"guid": "bookmarkAAA1",
"title": "A1",
}],
}, {
"guid": &BookmarkRootGuid::Mobile.as_guid(),
"children": [{
"guid": "bookmarkEEE2",
"title": "E2",
}, {
"guid": "bookmarkFFF2",
"title": "F2",
}],
}],
}),
);
// And verify our local tags are correct, too.
let expected_local_tags = &[
];
for (href, expected) in expected_local_tags {
let mut actual = tags::get_tags_for_url(&writer, &Url::parse(href).unwrap())?;
actual.sort();
assert_eq!(&actual, expected);
}
let expected_outgoing_ids = &[
"bookmarkAAA1", // A is new locally.
"bookmarkAAA2",
"bookmarkBBBB", // B has a duplicate tag.
"bookmarkCCC1", // C has mismatched tags.
"bookmarkCCC2",
"bookmarkCCC3",
"bookmarkFFF2", // F2 is missing tags.
"menu", // Roots always get uploaded on the first sync.
"mobile",
"toolbar",
"unfiled",
];
assert_eq!(
outgoing
.iter()
.map(|p| p.envelope.id.as_str())
.collect::<Vec<_>>(),
expected_outgoing_ids,
"Should upload new bookmarks and fix up tags",
);
// Now push the records back to the engine, so we can check what we're
// uploading.
engine
.set_uploaded(
ServerTimestamp(0),
expected_outgoing_ids.iter().map(SyncGuid::from).collect(),
)
.expect("Should push synced changes back to the engine");
engine.sync_finished().expect("should work");
// A and C should have the same URL and tags, and should be valid now.
// Because the builder methods take a `&mut SyncedBookmarkItem`, and we
// want to hang on to our base items for cloning later, we can't use
// one-liners to create them.
let mut synced_item_for_a = SyncedBookmarkItem::new();
synced_item_for_a
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.tags(["one", "two"].iter().map(|&tag| tag.into()).collect());
let mut synced_item_for_b = SyncedBookmarkItem::new();
synced_item_for_b
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.tags(
["eight", "three", "two"]
.iter()
.map(|&tag| tag.into())
.collect(),
)
.parent_guid(Some(&BookmarkRootGuid::Unfiled.as_guid()))
.title(Some("B"));
let mut synced_item_for_c = SyncedBookmarkItem::new();
synced_item_for_c
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.tags(
["five", "four", "seven", "six"]
.iter()
.map(|&tag| tag.into())
.collect(),
);
let mut synced_item_for_f = SyncedBookmarkItem::new();
synced_item_for_f
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.tags(vec!["twelve".into()]);
// A table-driven test to clean up some of the boilerplate. We clone
// the base item for each test, and pass it to the boxed closure to set
// additional properties.
let expected_synced_items = &[
ExpectedSyncedItem::with_properties("bookmarkAAA1", &synced_item_for_a, |a| {
a.parent_guid(Some(&BookmarkRootGuid::Unfiled.as_guid()))
.title(Some("A1"))
}),
ExpectedSyncedItem::with_properties("bookmarkAAA2", &synced_item_for_a, |a| {
a.parent_guid(Some(&BookmarkRootGuid::Menu.as_guid()))
.title(Some("A2"))
}),
ExpectedSyncedItem::new("bookmarkBBBB", &synced_item_for_b),
ExpectedSyncedItem::with_properties("bookmarkCCC1", &synced_item_for_c, |c| {
c.parent_guid(Some(&BookmarkRootGuid::Unfiled.as_guid()))
.title(Some("C1"))
}),
ExpectedSyncedItem::with_properties("bookmarkCCC2", &synced_item_for_c, |c| {
c.parent_guid(Some(&BookmarkRootGuid::Menu.as_guid()))
.title(Some("C2"))
}),
ExpectedSyncedItem::with_properties("bookmarkCCC3", &synced_item_for_c, |c| {
c.parent_guid(Some(&BookmarkRootGuid::Menu.as_guid()))
.title(Some("C3"))
}),
ExpectedSyncedItem::with_properties(
// We didn't reupload F1, but let's make sure it's still valid.
"bookmarkFFF1",
&synced_item_for_f,
|f| {
f.parent_guid(Some(&BookmarkRootGuid::Toolbar.as_guid()))
.title(Some("F1"))
},
),
ExpectedSyncedItem::with_properties("bookmarkFFF2", &synced_item_for_f, |f| {
f.parent_guid(Some(&BookmarkRootGuid::Mobile.as_guid()))
.title(Some("F2"))
}),
];
for item in expected_synced_items {
item.check(&writer)?;
}
Ok(())
}
#[test]
fn test_apply_bookmark_tags() -> Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
// Insert local item with tagged URL.
insert_bookmark(
&writer,
InsertableBookmark {
parent_guid: BookmarkRootGuid::Unfiled.as_guid(),
position: BookmarkPosition::Append,
date_added: None,
last_modified: None,
guid: Some("bookmarkAAAA".into()),
title: Some("A".into()),
}
.into(),
)?;
let mut tags_for_a =
tags_for_a.sort();
assert_eq!(tags_for_a, vec!["one".to_owned()]);
assert_incoming_creates_local_tree(
&api,
json!([{
"id": "bookmarkBBBB",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"dateAdded": 1_381_542_355_843u64,
"title": "B",
"tags": ["one", "two"],
}, {
"id": "bookmarkCCCC",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"dateAdded": 1_381_542_355_843u64,
"title": "C",
"tags": ["three"],
}, {
"id": "unfiled",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Unfiled",
"children": ["bookmarkBBBB", "bookmarkCCCC"],
}]),
&BookmarkRootGuid::Unfiled.as_guid(),
json!({"children" : [
]}),
);
let mut tags_for_a =
tags_for_a.sort();
assert_eq!(tags_for_a, vec!["one".to_owned()]);
let mut tags_for_b =
tags_for_b.sort();
assert_eq!(tags_for_b, vec!["one".to_owned(), "two".to_owned()]);
let mut tags_for_c =
tags_for_c.sort();
assert_eq!(tags_for_c, vec!["three".to_owned()]);
let synced_item_for_a = SyncedBookmarkItem::get(&writer, &"bookmarkAAAA".into())
.expect("Should fetch A")
.expect("A should exist");
assert_eq!(
synced_item_for_a,
*SyncedBookmarkItem::new()
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.parent_guid(Some(&BookmarkRootGuid::Unfiled.as_guid()))
.title(Some("A"))
.tags(vec!["one".into()])
);
let synced_item_for_b = SyncedBookmarkItem::get(&writer, &"bookmarkBBBB".into())
.expect("Should fetch B")
.expect("B should exist");
assert_eq!(
synced_item_for_b,
*SyncedBookmarkItem::new()
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.parent_guid(Some(&BookmarkRootGuid::Unfiled.as_guid()))
.title(Some("B"))
.tags(vec!["one".into(), "two".into()])
);
Ok(())
}
#[test]
fn test_apply_bookmark_keyword() -> Result<()> {
let api = new_mem_api();
let records = json!([{
"id": "bookmarkAAAA",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"dateAdded": 1_381_542_355_843u64,
"title": "A",
"keyword": "ex",
},
{
"id": "unfiled",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Unfiled",
"children": ["bookmarkAAAA"],
}]);
let db_mutex = api.get_sync_connection().unwrap();
let db = db_mutex.lock();
let tx = db.begin_transaction()?;
let applicator = IncomingApplicator::new(&db);
if let Value::Array(records) = records {
for record in records {
applicator.apply_bso(IncomingBso::from_test_content(record))?;
}
} else {
unreachable!("JSON records must be an array");
}
tx.commit()?;
// Flag the bookmark with the keyword for reupload, so that we can
// ensure the keyword is round-tripped correctly.
db.execute(
"UPDATE moz_bookmarks_synced SET
validity = :validity
WHERE guid = :guid",
rusqlite::named_params! {
":validity": SyncedBookmarkValidity::Reupload,
":guid": SyncGuid::from("bookmarkAAAA"),
},
)?;
let interrupt_scope = db.begin_interrupt_scope()?;
let mut merger = Merger::new(&db, &interrupt_scope, ServerTimestamp(0));
merger.merge()?;
assert_local_json_tree(
&db,
&BookmarkRootGuid::Unfiled.as_guid(),
);
let outgoing = fetch_outgoing_records(&db, &interrupt_scope)?;
let record_for_a = outgoing
.iter()
.find(|payload| payload.envelope.id == "bookmarkAAAA")
.expect("Should reupload A");
let bk = record_for_a.to_test_incoming_t::<BookmarkRecord>();
assert_eq!(bk.keyword.unwrap(), "ex");
Ok(())
}
#[test]
fn test_apply_query() {
// should we add some more query variations here?
let api = new_mem_api();
assert_incoming_creates_local_tree(
&api,
json!([{
"id": "query1______",
"type": "query",
"parentid": "unfiled",
"parentName": "Unfiled Bookmarks",
"dateAdded": 1_381_542_355_843u64,
"title": "Some query",
"bmkUri": "place:tag=foo",
},
{
"id": "unfiled",
"type": "folder",
"parentid": "places",
"dateAdded": 1_381_542_355_843u64,
"title": "Unfiled",
"children": ["query1______"],
}]),
&BookmarkRootGuid::Unfiled.as_guid(),
json!({"children" : [{"guid": "query1______", "url": "place:tag=foo"}]}),
);
let reader = api
.open_connection(ConnectionType::ReadOnly)
.expect("Should open read-only connection");
assert!(
frecency_stale_at(&reader, &Url::parse("place:tag=foo").unwrap())
.expect("Should check stale frecency")
.is_none(),
"Should not mark frecency for queries as stale"
);
}
#[test]
fn test_apply() -> Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
let db = api.get_sync_connection().unwrap();
let syncer = db.lock();
syncer
.execute("UPDATE moz_bookmarks SET syncChangeCounter = 0", [])
.expect("should work");
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [
{
"guid": "bookmarkAAAA",
"title": "A",
},
{
"guid": "bookmarkBBBB",
"title": "B",
},
]
}),
);
tags::tag_url(
&writer,
"baz",
)
.expect("Should tag A");
let records = vec![
json!({
"id": "bookmarkCCCC",
"type": "bookmark",
"parentid": "menu",
"parentName": "menu",
"dateAdded": 1_552_183_116_885u64,
"title": "C",
"tags": ["foo", "bar"],
}),
json!({
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "menu",
"children": ["bookmarkCCCC"],
}),
];
// Drop the sync connection to avoid a deadlock when the sync engine locks the mutex
drop(syncer);
let engine = create_sync_engine(&api);
let incoming = records
.into_iter()
.map(IncomingBso::from_test_content)
.collect();
let mut outgoing = engine_apply_incoming(&engine, incoming);
outgoing.sort_by(|a, b| a.envelope.id.cmp(&b.envelope.id));
assert_eq!(
outgoing
.iter()
.map(|p| p.envelope.id.as_str())
.collect::<Vec<_>>(),
vec!["bookmarkAAAA", "bookmarkBBBB", "unfiled",]
);
let record_for_a = outgoing
.iter()
.find(|p| p.envelope.id == "bookmarkAAAA")
.expect("Should upload A");
let content_for_a = record_for_a.to_test_incoming_t::<BookmarkRecord>();
assert_eq!(content_for_a.tags, vec!["baz".to_string()]);
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Root.as_guid(),
json!({
"guid": &BookmarkRootGuid::Root.as_guid(),
"children": [
{
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [
{
"guid": "bookmarkCCCC",
"title": "C",
"date_added": Timestamp(1_552_183_116_885),
},
],
},
{
"guid": &BookmarkRootGuid::Toolbar.as_guid(),
"children": [],
},
{
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [
{
"guid": "bookmarkAAAA",
"title": "A",
},
{
"guid": "bookmarkBBBB",
"title": "B",
},
],
},
{
"guid": &BookmarkRootGuid::Mobile.as_guid(),
"children": [],
},
],
}),
);
// We haven't finished the sync yet, so all local change counts for
// items to upload should still be > 0.
let guid_for_a: SyncGuid = "bookmarkAAAA".into();
let info_for_a = get_raw_bookmark(&writer, &guid_for_a)
.expect("Should fetch info for A")
.unwrap();
assert_eq!(info_for_a._sync_change_counter, 2);
let info_for_unfiled = get_raw_bookmark(&writer, &BookmarkRootGuid::Unfiled.as_guid())
.expect("Should fetch info for unfiled")
.unwrap();
assert_eq!(info_for_unfiled._sync_change_counter, 2);
engine
.set_uploaded(
ServerTimestamp(0),
vec![
"bookmarkAAAA".into(),
"bookmarkBBBB".into(),
"unfiled".into(),
],
)
.expect("Should push synced changes back to the engine");
engine.sync_finished().expect("finish always works");
let info_for_a = get_raw_bookmark(&writer, &guid_for_a)
.expect("Should fetch info for A")
.unwrap();
assert_eq!(info_for_a._sync_change_counter, 0);
let info_for_unfiled = get_raw_bookmark(&writer, &BookmarkRootGuid::Unfiled.as_guid())
.expect("Should fetch info for unfiled")
.unwrap();
assert_eq!(info_for_unfiled._sync_change_counter, 0);
let mut tags_for_c = tags::get_tags_for_url(
&writer,
)
.expect("Should return tags for C");
tags_for_c.sort();
assert_eq!(tags_for_c, &["bar", "foo"]);
Ok(())
}
#[test]
fn test_apply_invalid_url() -> Result<()> {
let api = new_mem_api();
let db = api.get_sync_connection().unwrap();
let syncer = db.lock();
syncer
.execute("UPDATE moz_bookmarks SET syncChangeCounter = 0", [])
.expect("should work");
let records = vec![
json!({
"id": "bookmarkXXXX",
"type": "bookmark",
"parentid": "menu",
"parentName": "menu",
"dateAdded": 1_552_183_116_885u64,
"title": "Invalid",
"bmkUri": "invalid url",
}),
json!({
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "menu",
"children": ["bookmarkXXXX"],
}),
];
// Drop the sync connection to avoid a deadlock when the sync engine locks the mutex
drop(syncer);
let engine = create_sync_engine(&api);
let incoming = records
.into_iter()
.map(IncomingBso::from_test_content)
.collect();
let mut outgoing = engine_apply_incoming(&engine, incoming);
outgoing.sort_by(|a, b| a.envelope.id.cmp(&b.envelope.id));
assert_eq!(
outgoing
.iter()
.map(|p| p.envelope.id.as_str())
.collect::<Vec<_>>(),
vec!["bookmarkXXXX", "menu",]
);
let record_for_invalid = outgoing
.iter()
.find(|p| p.envelope.id == "bookmarkXXXX")
.expect("Should re-upload the invalid record");
assert!(
matches!(
record_for_invalid
.to_test_incoming()
.into_content::<BookmarkRecord>()
.kind,
IncomingKind::Tombstone
),
"is invalid record"
);
let record_for_menu = outgoing
.iter()
.find(|p| p.envelope.id == "menu")
.expect("Should upload menu");
let content_for_menu = record_for_menu.to_test_incoming_t::<FolderRecord>();
assert!(
content_for_menu.children.is_empty(),
"should have been removed from the parent"
);
Ok(())
}
#[test]
fn test_apply_tombstones() -> Result<()> {
let local_modified = Timestamp::now();
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [{
"guid": "bookmarkAAAA",
"title": "A",
"date_added": local_modified,
"last_modified": local_modified,
}, {
"guid": "separatorAAA",
"type": BookmarkType::Separator as u8,
"date_added": local_modified,
"last_modified": local_modified,
}, {
"guid": "folderAAAAAA",
"children": [{
"guid": "bookmarkBBBB",
"title": "b",
"date_added": local_modified,
"last_modified": local_modified,
}],
}],
}),
);
// a first sync, which will populate our mirror.
let engine = create_sync_engine(&api);
let outgoing = engine_apply_incoming(&engine, vec![]);
let outgoing_ids = outgoing
.iter()
.map(|p| p.envelope.id.clone())
.collect::<Vec<_>>();
// 4 roots + 4 items
assert_eq!(outgoing_ids.len(), 8, "{:?}", outgoing_ids);
engine
.set_uploaded(ServerTimestamp(0), outgoing_ids)
.expect("should work");
engine.sync_finished().expect("should work");
// Now the next sync with incoming tombstones.
let remote_unfiled = json!({
"id": "unfiled",
"type": "folder",
"parentid": "places",
"title": "Unfiled",
"children": [],
});
let incoming = vec![
IncomingBso::new_test_tombstone(Guid::new("bookmarkAAAA")),
IncomingBso::new_test_tombstone(Guid::new("separatorAAA")),
IncomingBso::new_test_tombstone(Guid::new("folderAAAAAA")),
IncomingBso::new_test_tombstone(Guid::new("bookmarkBBBB")),
IncomingBso::from_test_content(remote_unfiled),
];
let outgoing = engine_apply_incoming(&engine, incoming);
let outgoing_ids = outgoing
.iter()
.map(|p| p.envelope.id.clone())
.collect::<Vec<_>>();
assert_eq!(outgoing_ids.len(), 0, "{:?}", outgoing_ids);
engine
.set_uploaded(ServerTimestamp(0), outgoing_ids)
.expect("should work");
engine.sync_finished().expect("should work");
// We deleted everything from unfiled.
assert_local_json_tree(
&api.get_sync_connection().unwrap().lock(),
&BookmarkRootGuid::Unfiled.as_guid(),
json!({"children" : []}),
);
Ok(())
}
#[test]
fn test_keywords() -> Result<()> {
use crate::storage::bookmarks::bookmarks_get_url_for_keyword;
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
let records = vec![
json!({
"id": "toolbar",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "toolbar",
"children": ["bookmarkAAAA"],
}),
json!({
"id": "bookmarkAAAA",
"type": "bookmark",
"parentid": "toolbar",
"parentName": "toolbar",
"dateAdded": 1_552_183_116_885u64,
"title": "A",
"keyword": "a",
}),
];
let engine = create_sync_engine(&api);
let incoming = records
.into_iter()
.map(IncomingBso::from_test_content)
.collect();
let outgoing = engine_apply_incoming(&engine, incoming);
let mut outgoing_ids = outgoing
.iter()
.map(|p| p.envelope.id.clone())
.collect::<Vec<_>>();
outgoing_ids.sort();
assert_eq!(outgoing_ids, &["menu", "mobile", "toolbar", "unfiled"],);
assert_eq!(
bookmarks_get_url_for_keyword(&writer, "a")?,
);
engine
.set_uploaded(ServerTimestamp(0), outgoing_ids)
.expect("Should push synced changes back to the engine");
engine.sync_finished().expect("should work");
update_bookmark(
&writer,
&"bookmarkAAAA".into(),
&UpdatableBookmark {
title: Some("A (local)".into()),
..UpdatableBookmark::default()
}
.into(),
)?;
let outgoing = engine_apply_incoming(&engine, vec![]);
assert_eq!(outgoing.len(), 1);
let bk = outgoing[0].to_test_incoming_t::<BookmarkRecord>();
assert_eq!(bk.record_id.as_guid(), "bookmarkAAAA");
assert_eq!(bk.keyword.unwrap(), "a");
// URLs with keywords should have a foreign count of 3 (one for the
// local bookmark, one for the synced bookmark, and one for the
// keyword), and we shouldn't allow deleting them until the keyword
// is removed.
let foreign_count = writer
.try_query_row(
"SELECT foreign_count FROM moz_places
WHERE url_hash = hash(:url) AND
url = :url",
|row| -> rusqlite::Result<_> { row.get::<_, i64>(0) },
false,
)?
.expect("Should fetch foreign count for URL A");
assert_eq!(foreign_count, 3);
let err = writer
.execute(
"DELETE FROM moz_places
WHERE url_hash = hash(:url) AND
url = :url",
rusqlite::named_params! {
},
)
.expect_err("Should fail to delete URL A with keyword");
match err {
RusqlError::SqliteFailure(e, _) => assert_eq!(e.code, ErrorCode::ConstraintViolation),
_ => panic!("Wanted constraint violation error; got {:?}", err),
}
Ok(())
}
#[test]
fn test_apply_complex_bookmark_keywords() -> Result<()> {
use crate::storage::bookmarks::bookmarks_get_url_for_keyword;
// We don't provide an API for setting keywords locally, but we'll
// still round-trip and fix up keywords on the server.
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
// Let's add some remote bookmarks with keywords.
let remote_records = json!([{
// A1 and A2 have the same URL and keyword, so we shouldn't
// reupload them.
"id": "bookmarkAAA1",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"title": "A1",
"keyword": "one",
}, {
"id": "bookmarkAAA2",
"type": "bookmark",
"parentid": "menu",
"parentName": "Menu",
"title": "A2",
"keyword": "one",
}, {
// B1 and B2 have mismatched keywords, and we should reupload
// both of them. It's not specified which keyword wins, but
// reuploading both means we make them consistent.
"id": "bookmarkBBB1",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"title": "B1",
"keyword": "two",
}, {
"id": "bookmarkBBB2",
"type": "bookmark",
"parentid": "menu",
"parentName": "Menu",
"title": "B2",
"keyword": "three",
}, {
// C1 has a keyword; C2 doesn't. As with B, which one wins
// depends on which record we apply last, and how SQLite
// processes the rows, but we should reupload both.
"id": "bookmarkCCC1",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"title": "C1",
"keyword": "four",
}, {
"id": "bookmarkCCC2",
"type": "bookmark",
"parentid": "menu",
"parentName": "Menu",
"title": "C2",
}, {
// D has a keyword that needs to be cleaned up before
// inserting. In this case, we intentionally don't reupload.
"id": "bookmarkDDDD",
"type": "bookmark",
"parentid": "unfiled",
"parentName": "Unfiled",
"title": "D",
"keyword": " FIVE ",
}, {
"id": "unfiled",
"type": "folder",
"parentid": "places",
"title": "Unfiled",
"children": ["bookmarkAAA1", "bookmarkBBB1", "bookmarkCCC1", "bookmarkDDDD"],
}, {
"id": "menu",
"type": "folder",
"parentid": "places",
"title": "Menu",
"children": ["bookmarkAAA2", "bookmarkBBB2", "bookmarkCCC2"],
}]);
let engine = create_sync_engine(&api);
let incoming = if let Value::Array(records) = remote_records {
records
.into_iter()
.map(IncomingBso::from_test_content)
.collect()
} else {
unreachable!("JSON records must be an array");
};
let mut outgoing = engine_apply_incoming(&engine, incoming);
outgoing.sort_by(|a, b| a.envelope.id.cmp(&b.envelope.id));
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Root.as_guid(),
json!({
"guid": &BookmarkRootGuid::Root.as_guid(),
"children": [{
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
"guid": "bookmarkAAA2",
"title": "A2",
}, {
"guid": "bookmarkBBB2",
"title": "B2",
}, {
"guid": "bookmarkCCC2",
"title": "C2",
}],
}, {
"guid": &BookmarkRootGuid::Toolbar.as_guid(),
"children": [],
}, {
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [{
"guid": "bookmarkAAA1",
"title": "A1",
}, {
"guid": "bookmarkBBB1",
"title": "B1",
}, {
"guid": "bookmarkCCC1",
"title": "C1",
}, {
"guid": "bookmarkDDDD",
"title": "D",
}],
}, {
"guid": &BookmarkRootGuid::Mobile.as_guid(),
"children": [],
}],
}),
);
// And verify our local keywords are correct, too.
let url_for_one = bookmarks_get_url_for_keyword(&writer, "one")?
.expect("Should have URL for keyword `one`");
let keyword_for_b = match (
bookmarks_get_url_for_keyword(&writer, "two")?,
bookmarks_get_url_for_keyword(&writer, "three")?,
) {
(Some(url), None) => {
"two".to_string()
}
(None, Some(url)) => {
"three".to_string()
}
(Some(_), Some(_)) => panic!("Should pick `two` or `three`, not both"),
(None, None) => panic!("Should have URL for either `two` or `three`"),
};
let keyword_for_c = match bookmarks_get_url_for_keyword(&writer, "four")? {
Some(url) => {
Some("four".to_string())
}
None => None,
};
let url_for_five = bookmarks_get_url_for_keyword(&writer, "five")?
.expect("Should have URL for keyword `five`");
let expected_outgoing_keywords = &[
("bookmarkBBB1", Some(keyword_for_b.clone())),
("bookmarkBBB2", Some(keyword_for_b.clone())),
("bookmarkCCC1", keyword_for_c.clone()),
("bookmarkCCC2", keyword_for_c.clone()),
("menu", None), // Roots always get uploaded on the first sync.
("mobile", None),
("toolbar", None),
("unfiled", None),
];
assert_eq!(
outgoing
.iter()
.map(|p| (
p.envelope.id.as_str(),
p.to_test_incoming_t::<BookmarkRecord>().keyword
))
.collect::<Vec<_>>(),
expected_outgoing_keywords,
"Should upload new bookmarks and fix up keywords",
);
// Now push the records back to the engine, so we can check what we're
// uploading.
engine
.set_uploaded(
ServerTimestamp(0),
expected_outgoing_keywords
.iter()
.map(|(id, _)| SyncGuid::from(id))
.collect(),
)
.expect("Should push synced changes back to the engine");
engine.sync_finished().expect("should work");
let mut synced_item_for_b = SyncedBookmarkItem::new();
synced_item_for_b
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.keyword(Some(&keyword_for_b));
let mut synced_item_for_c = SyncedBookmarkItem::new();
synced_item_for_c
.validity(SyncedBookmarkValidity::Valid)
.kind(SyncedBookmarkKind::Bookmark)
.keyword(Some(keyword_for_c.unwrap().as_str()));
let expected_synced_items = &[
ExpectedSyncedItem::with_properties("bookmarkBBB1", &synced_item_for_b, |a| {
a.parent_guid(Some(&BookmarkRootGuid::Unfiled.as_guid()))
.title(Some("B1"))
}),
ExpectedSyncedItem::with_properties("bookmarkBBB2", &synced_item_for_b, |a| {
a.parent_guid(Some(&BookmarkRootGuid::Menu.as_guid()))
.title(Some("B2"))
}),
ExpectedSyncedItem::with_properties("bookmarkCCC1", &synced_item_for_c, |a| {
a.parent_guid(Some(&BookmarkRootGuid::Unfiled.as_guid()))
.title(Some("C1"))
}),
ExpectedSyncedItem::with_properties("bookmarkCCC2", &synced_item_for_c, |a| {
a.parent_guid(Some(&BookmarkRootGuid::Menu.as_guid()))
.title(Some("C2"))
}),
];
for item in expected_synced_items {
item.check(&writer)?;
}
Ok(())
}
#[test]
fn test_wipe() -> Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
let records = vec![
json!({
"id": "toolbar",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "toolbar",
"children": ["folderAAAAAA"],
}),
json!({
"id": "folderAAAAAA",
"type": "folder",
"parentid": "toolbar",
"parentName": "toolbar",
"dateAdded": 0,
"title": "A",
"children": ["bookmarkBBBB"],
}),
json!({
"id": "bookmarkBBBB",
"type": "bookmark",
"parentid": "folderAAAAAA",
"parentName": "A",
"dateAdded": 0,
"title": "A",
}),
json!({
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "menu",
"children": ["folderCCCCCC"],
}),
json!({
"id": "folderCCCCCC",
"type": "folder",
"parentid": "menu",
"parentName": "menu",
"dateAdded": 0,
"title": "A",
"children": ["bookmarkDDDD", "folderEEEEEE"],
}),
json!({
"id": "bookmarkDDDD",
"type": "bookmark",
"parentid": "folderCCCCCC",
"parentName": "C",
"dateAdded": 0,
"title": "D",
}),
json!({
"id": "folderEEEEEE",
"type": "folder",
"parentid": "folderCCCCCC",
"parentName": "C",
"dateAdded": 0,
"title": "E",
"children": ["bookmarkFFFF"],
}),
json!({
"id": "bookmarkFFFF",
"type": "bookmark",
"parentid": "folderEEEEEE",
"parentName": "E",
"dateAdded": 0,
"title": "F",
}),
];
let engine = create_sync_engine(&api);
let incoming = records
.into_iter()
.map(IncomingBso::from_test_content)
.collect();
let outgoing = engine_apply_incoming(&engine, incoming);
let mut outgoing_ids = outgoing
.iter()
.map(|p| p.envelope.id.clone())
.collect::<Vec<_>>();
outgoing_ids.sort();
assert_eq!(outgoing_ids, &["menu", "mobile", "toolbar", "unfiled"],);
engine
.set_uploaded(ServerTimestamp(0), outgoing_ids)
.expect("Should push synced changes back to the engine");
engine.sync_finished().expect("should work");
engine.wipe().expect("Should wipe the store");
// Wiping the store should delete all items except for the roots.
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Root.as_guid(),
json!({
"guid": &BookmarkRootGuid::Root.as_guid(),
"children": [
{
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [],
},
{
"guid": &BookmarkRootGuid::Toolbar.as_guid(),
"children": [],
},
{
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [],
},
{
"guid": &BookmarkRootGuid::Mobile.as_guid(),
"children": [],
},
],
}),
);
// Now pretend that F changed remotely between the time we called `wipe`
// and the next sync.
let record_for_f = json!({
"id": "bookmarkFFFF",
"type": "bookmark",
"parentid": "folderEEEEEE",
"parentName": "E",
"dateAdded": 0,
"title": "F (remote)",
});
let incoming = vec![IncomingBso::from_test_content_ts(
record_for_f,
ServerTimestamp(1000),
)];
let outgoing = engine_apply_incoming(&engine, incoming);
let (outgoing_tombstones, outgoing_records): (Vec<_>, Vec<_>) =
outgoing.iter().partition(|record| {
matches!(
record
.to_test_incoming()
.into_content::<BookmarkRecord>()
.kind,
IncomingKind::Tombstone
)
});
let mut outgoing_record_ids = outgoing_records
.iter()
.map(|p| p.envelope.id.as_str())
.collect::<Vec<_>>();
outgoing_record_ids.sort_unstable();
assert_eq!(
outgoing_record_ids,
&["bookmarkFFFF", "menu", "mobile", "toolbar", "unfiled"],
);
let mut outgoing_tombstone_ids = outgoing_tombstones
.iter()
.map(|p| p.envelope.id.clone())
.collect::<Vec<_>>();
outgoing_tombstone_ids.sort();
assert_eq!(
outgoing_tombstone_ids,
&[
"bookmarkBBBB",
"bookmarkDDDD",
"folderAAAAAA",
"folderCCCCCC",
"folderEEEEEE"
]
);
// F should move to the closest surviving ancestor, which, in this case,
// is the menu.
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Root.as_guid(),
json!({
"guid": &BookmarkRootGuid::Root.as_guid(),
"children": [
{
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [
{
"guid": "bookmarkFFFF",
"title": "F (remote)",
},
],
},
{
"guid": &BookmarkRootGuid::Toolbar.as_guid(),
"children": [],
},
{
"guid": &BookmarkRootGuid::Unfiled.as_guid(),
"children": [],
},
{
"guid": &BookmarkRootGuid::Mobile.as_guid(),
"children": [],
},
],
}),
);
Ok(())
}
#[test]
fn test_reset() -> anyhow::Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [
{
"guid": "bookmark2___",
"title": "2",
}
],
}),
);
{
// scope to kill our sync connection.
let engine = create_sync_engine(&api);
assert_eq!(
engine.get_sync_assoc()?,
EngineSyncAssociation::Disconnected
);
let outgoing = engine_apply_incoming(&engine, vec![]);
let synced_ids: Vec<Guid> = outgoing.into_iter().map(|c| c.envelope.id).collect();
assert_eq!(synced_ids.len(), 5, "should be 4 roots + 1 outgoing item");
engine.set_uploaded(ServerTimestamp(2_000), synced_ids)?;
engine.sync_finished().expect("should work");
let db = api.get_sync_connection().unwrap();
let syncer = db.lock();
assert_eq!(get_meta::<i64>(&syncer, LAST_SYNC_META_KEY)?, Some(2_000));
let sync_ids = CollSyncIds {
global: Guid::random(),
coll: Guid::random(),
};
// Temporarily drop the sync connection to avoid a deadlock when the sync engine locks
// the mutex
drop(syncer);
engine.reset(&EngineSyncAssociation::Connected(sync_ids.clone()))?;
let syncer = db.lock();
assert_eq!(
get_meta::<Guid>(&syncer, GLOBAL_SYNCID_META_KEY)?,
Some(sync_ids.global)
);
assert_eq!(
get_meta::<Guid>(&syncer, COLLECTION_SYNCID_META_KEY)?,
Some(sync_ids.coll)
);
assert_eq!(get_meta::<i64>(&syncer, LAST_SYNC_META_KEY)?, Some(0));
}
// do it all again - after the reset we should get the same results.
{
let engine = create_sync_engine(&api);
let outgoing = engine_apply_incoming(&engine, vec![]);
let synced_ids: Vec<Guid> = outgoing.into_iter().map(|c| c.envelope.id).collect();
assert_eq!(synced_ids.len(), 5, "should be 4 roots + 1 outgoing item");
engine.set_uploaded(ServerTimestamp(2_000), synced_ids)?;
engine.sync_finished().expect("should work");
let db = api.get_sync_connection().unwrap();
let syncer = db.lock();
assert_eq!(get_meta::<i64>(&syncer, LAST_SYNC_META_KEY)?, Some(2_000));
// Temporarily drop the sync connection to avoid a deadlock when the sync engine locks
// the mutex
drop(syncer);
engine.reset(&EngineSyncAssociation::Disconnected)?;
let syncer = db.lock();
assert_eq!(
get_meta::<Option<String>>(&syncer, GLOBAL_SYNCID_META_KEY)?,
None
);
assert_eq!(
get_meta::<Option<String>>(&syncer, COLLECTION_SYNCID_META_KEY)?,
None
);
assert_eq!(get_meta::<i64>(&syncer, LAST_SYNC_META_KEY)?, Some(0));
}
Ok(())
}
#[test]
fn test_incoming_timestamps() -> anyhow::Result<()> {
let api = new_mem_api();
let reader = api.open_connection(ConnectionType::ReadOnly)?;
// The timestamp of each record on the server. We expect this to be our "last modified".
let remote_modified = ServerTimestamp::from_millis(1770000000000);
let records = vec![
json!({
"id": "toolbar",
"type": "folder",
"parentid": "places",
"parentName": "",
"dateAdded": 0,
"title": "toolbar",
"children": ["folderAAAAAA"],
}),
json!({
"id": "folderAAAAAA",
"type": "folder",
"parentid": "toolbar",
"parentName": "toolbar",
"dateAdded": 0,
"title": "A",
"children": ["bookmarkBBBB"],
}),
json!({
"id": "bookmarkBBBB",
"type": "bookmark",
"parentid": "folderAAAAAA",
"parentName": "A",
"dateAdded": 0,
"title": "A",
}),
];
let engine = create_sync_engine(&api);
let incoming = records
.clone()
.into_iter()
.map(|json| IncomingBso::from_test_content_ts(json, remote_modified))
.collect();
engine_apply_incoming(&engine, incoming);
// This was the first creation of the bookmark, the lastModified should be the server timestamp.
let bm = get_raw_bookmark(&reader, &SyncGuid::new("bookmarkBBBB"))
.expect("must work")
.expect("must exist");
assert_eq!(
bm.date_modified.as_millis_i64(),
remote_modified.as_millis()
);
// Now reset the engine and do it again, which should not adjust date_modified.
engine.reset(&EngineSyncAssociation::Disconnected)?;
let incoming = records
.into_iter()
.map(|json| IncomingBso::from_test_content_ts(json, remote_modified))
.collect();
engine_apply_incoming(&engine, incoming);
let bm = get_raw_bookmark(&reader, &SyncGuid::new("bookmarkBBBB"))
.expect("must work")
.expect("must exist");
assert_eq!(
bm.date_modified.as_millis_i64(),
remote_modified.as_millis()
);
// applying a change to the bookmark should update it.
let new_records = vec![json!({
"id": "bookmarkBBBB",
"type": "bookmark",
"parentid": "folderAAAAAA",
"parentName": "A",
"dateAdded": 0,
"title": "A",
})];
let new_remote_modified = ServerTimestamp::from_millis(1780000000000);
let new_incoming = new_records
.into_iter()
.map(|json| IncomingBso::from_test_content_ts(json, new_remote_modified))
.collect();
engine_apply_incoming(&engine, new_incoming);
let bm = get_raw_bookmark(&reader, &SyncGuid::new("bookmarkBBBB"))
.expect("must work")
.expect("must exist");
assert_eq!(
bm.date_modified.as_millis_i64(),
new_remote_modified.as_millis()
);
Ok(())
}
#[test]
fn test_dedupe_local_newer() -> anyhow::Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
let local_modified = Timestamp::now();
let remote_modified = local_modified.as_millis() as f64 / 1000f64 - 5f64;
// Start with merged items.
apply_incoming(
&api,
ServerTimestamp::from_float_seconds(remote_modified),
json!([{
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"title": "menu",
"children": ["bookmarkAAA5"],
}, {
"id": "bookmarkAAA5",
"type": "bookmark",
"parentid": "menu",
"parentName": "menu",
"title": "A",
}]),
);
// Add newer local dupes.
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
"guid": "bookmarkAAA1",
"title": "A",
"date_added": local_modified,
"last_modified": local_modified,
}, {
"guid": "bookmarkAAA2",
"title": "A",
"date_added": local_modified,
"last_modified": local_modified,
}, {
"guid": "bookmarkAAA3",
"title": "A",
"date_added": local_modified,
"last_modified": local_modified,
}],
}),
);
// Add older remote dupes.
apply_incoming(
&api,
ServerTimestamp(local_modified.as_millis() as i64),
json!([{
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"title": "menu",
"children": ["bookmarkAAAA", "bookmarkAAA4", "bookmarkAAA5"],
}, {
"id": "bookmarkAAAA",
"type": "bookmark",
"parentid": "menu",
"parentName": "menu",
"title": "A",
}, {
"id": "bookmarkAAA4",
"type": "bookmark",
"parentid": "menu",
"parentName": "menu",
"title": "A",
}]),
);
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Menu.as_guid(),
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
"guid": "bookmarkAAAA",
"title": "A",
}, {
"guid": "bookmarkAAA4",
"title": "A",
}, {
"guid": "bookmarkAAA5",
"title": "A",
}, {
"guid": "bookmarkAAA3",
"title": "A",
}],
}),
);
Ok(())
}
#[test]
fn test_deduping_remote_newer() -> anyhow::Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
let local_modified = Timestamp::from(Timestamp::now().as_millis() - 5000);
let remote_modified = local_modified.as_millis() as f64 / 1000f64;
// Start with merged items.
apply_incoming(
&api,
ServerTimestamp::from_float_seconds(remote_modified),
json!([{
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"title": "menu",
"children": ["folderAAAAAA"],
}, {
// Shouldn't dedupe to `folderA11111` because it's been applied.
"id": "folderAAAAAA",
"type": "folder",
"parentid": "menu",
"parentName": "menu",
"title": "A",
"children": ["bookmarkGGGG"],
}, {
// Shouldn't dedupe to `bookmarkG111`.
"id": "bookmarkGGGG",
"type": "bookmark",
"parentid": "folderAAAAAA",
"parentName": "A",
"title": "G",
}]),
);
// Add older local dupes.
insert_local_json_tree(
&writer,
json!({
"guid": "folderAAAAAA",
"children": [{
// Not a candidate for `bookmarkH111` because we didn't dupe `folderAAAAAA`.
"guid": "bookmarkHHHH",
"title": "H",
"date_added": local_modified,
"last_modified": local_modified,
}]
}),
);
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
// Should dupe to `folderB11111`.
"guid": "folderBBBBBB",
"type": BookmarkType::Folder as u8,
"title": "B",
"date_added": local_modified,
"last_modified": local_modified,
"children": [{
// Should dupe to `bookmarkC222`.
"guid": "bookmarkC111",
"title": "C",
"date_added": local_modified,
"last_modified": local_modified,
}, {
// Should dupe to `separatorF11` because the positions are the same.
"guid": "separatorFFF",
"type": BookmarkType::Separator as u8,
"date_added": local_modified,
"last_modified": local_modified,
}],
}, {
// Shouldn't dupe to `separatorE11`, because the positions are different.
"guid": "separatorEEE",
"type": BookmarkType::Separator as u8,
"date_added": local_modified,
"last_modified": local_modified,
}, {
// Shouldn't dupe to `bookmarkC222` because the parents are different.
"guid": "bookmarkCCCC",
"title": "C",
"date_added": local_modified,
"last_modified": local_modified,
}, {
// Should dupe to `queryD111111`.
"guid": "queryDDDDDDD",
"title": "Most Visited",
"url": "place:maxResults=10&sort=8",
"date_added": local_modified,
"last_modified": local_modified,
}],
}),
);
// Add newer remote items.
apply_incoming(
&api,
ServerTimestamp::from_float_seconds(remote_modified),
json!([{
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"title": "menu",
"children": ["folderAAAAAA", "folderB11111", "folderA11111", "separatorE11", "queryD111111"],
"dateAdded": local_modified.as_millis(),
}, {
"id": "folderB11111",
"type": "folder",
"parentid": "menu",
"parentName": "menu",
"title": "B",
"children": ["bookmarkC222", "separatorF11"],
"dateAdded": local_modified.as_millis(),
}, {
"id": "bookmarkC222",
"type": "bookmark",
"parentid": "folderB11111",
"parentName": "B",
"title": "C",
"dateAdded": local_modified.as_millis(),
}, {
"id": "separatorF11",
"type": "separator",
"parentid": "folderB11111",
"parentName": "B",
"dateAdded": local_modified.as_millis(),
}, {
"id": "folderA11111",
"type": "folder",
"parentid": "menu",
"parentName": "menu",
"title": "A",
"children": ["bookmarkG111"],
"dateAdded": local_modified.as_millis(),
}, {
"id": "bookmarkG111",
"type": "bookmark",
"parentid": "folderA11111",
"parentName": "A",
"title": "G",
"dateAdded": local_modified.as_millis(),
}, {
"id": "separatorE11",
"type": "separator",
"parentid": "folderB11111",
"parentName": "B",
"dateAdded": local_modified.as_millis(),
}, {
"id": "queryD111111",
"type": "query",
"parentid": "menu",
"parentName": "menu",
"title": "Most Visited",
"bmkUri": "place:maxResults=10&sort=8",
"dateAdded": local_modified.as_millis(),
}]),
);
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Menu.as_guid(),
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
"guid": "folderAAAAAA",
"children": [{
"guid": "bookmarkGGGG",
"title": "G",
}, {
"guid": "bookmarkHHHH",
"title": "H",
}]
}, {
"guid": "folderB11111",
"children": [{
"guid": "bookmarkC222",
"title": "C",
}, {
"guid": "separatorF11",
"type": BookmarkType::Separator as u8,
}],
}, {
"guid": "folderA11111",
"children": [{
"guid": "bookmarkG111",
"title": "G",
}]
}, {
"guid": "separatorE11",
"type": BookmarkType::Separator as u8,
}, {
"guid": "queryD111111",
"title": "Most Visited",
"url": "place:maxResults=10&sort=8",
}, {
"guid": "separatorEEE",
"type": BookmarkType::Separator as u8,
}, {
"guid": "bookmarkCCCC",
"title": "C",
}],
}),
);
Ok(())
}
#[test]
fn test_reconcile_sync_metadata() -> anyhow::Result<()> {
let api = new_mem_api();
let writer = api.open_connection(ConnectionType::ReadWrite)?;
let local_modified = Timestamp::from(Timestamp::now().as_millis() - 5000);
let remote_modified = local_modified.as_millis() as f64 / 1000f64;
insert_local_json_tree(
&writer,
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
// this folder is going to reconcile exactly
"guid": "folderAAAAAA",
"type": BookmarkType::Folder as u8,
"title": "A",
"date_added": local_modified,
"last_modified": local_modified,
"children": [{
"guid": "bookmarkBBBB",
"title": "B",
"date_added": local_modified,
"last_modified": local_modified,
}]
}, {
// this folder's existing child isn't on the server (so will be
// outgoing) and also will take a new child from the server.
"guid": "folderCCCCCC",
"type": BookmarkType::Folder as u8,
"title": "C",
"date_added": local_modified,
"last_modified": local_modified,
"children": [{
"guid": "bookmarkEEEE",
"title": "E",
"date_added": local_modified,
"last_modified": local_modified,
}]
}, {
// This bookmark is going to take the remote title.
"guid": "bookmarkFFFF",
"title": "f",
"date_added": local_modified,
"last_modified": local_modified,
}],
}),
);
let outgoing = apply_incoming(
&api,
ServerTimestamp::from_float_seconds(remote_modified),
json!([{
"id": "menu",
"type": "folder",
"parentid": "places",
"parentName": "",
"title": "menu",
"children": ["folderAAAAAA", "folderCCCCCC", "bookmarkFFFF"],
"dateAdded": local_modified.as_millis(),
}, {
"id": "folderAAAAAA",
"type": "folder",
"parentid": "menu",
"parentName": "menu",
"title": "A",
"children": ["bookmarkBBBB"],
"dateAdded": local_modified.as_millis(),
}, {
"id": "bookmarkBBBB",
"type": "bookmark",
"parentid": "folderAAAAAA",
"parentName": "A",
"title": "B",
"dateAdded": local_modified.as_millis(),
}, {
"id": "folderCCCCCC",
"type": "folder",
"parentid": "menu",
"parentName": "menu",
"title": "C",
"children": ["bookmarkDDDD"],
"dateAdded": local_modified.as_millis(),
}, {
"id": "bookmarkDDDD",
"type": "bookmark",
"parentid": "folderCCCCCC",
"parentName": "C",
"title": "D",
"dateAdded": local_modified.as_millis(),
}, {
"id": "bookmarkFFFF",
"type": "bookmark",
"parentid": "menu",
"parentName": "menu",
"title": "F",
"dateAdded": local_modified.as_millis(),
},]),
);
// Assert the tree is correct even though that's not really the point
// of this test.
assert_local_json_tree(
&writer,
&BookmarkRootGuid::Menu.as_guid(),
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
"children": [{
// this folder is going to reconcile exactly
"guid": "folderAAAAAA",
"type": BookmarkType::Folder as u8,
"title": "A",
"children": [{
"guid": "bookmarkBBBB",
"title": "B",
}]
}, {
"guid": "folderCCCCCC",
"type": BookmarkType::Folder as u8,
"title": "C",
"children": [{
"guid": "bookmarkDDDD",
"title": "D",
},{
"guid": "bookmarkEEEE",
"title": "E",
}]
}, {
"guid": "bookmarkFFFF",
"title": "F",
}],
}),
);
// After application everything should have SyncStatus::Normal and
// a change counter of zero.
for guid in &[
"folderAAAAAA",
"bookmarkBBBB",
"folderCCCCCC",
"bookmarkDDDD",
"bookmarkFFFF",
] {
let bm = get_raw_bookmark(&writer, &guid.into())
.expect("must work")
.expect("must exist");
assert_eq!(bm._sync_status, SyncStatus::Normal, "{}", guid);
assert_eq!(bm._sync_change_counter, 0, "{}", guid);
}
// And bookmarkEEEE wasn't on the server, so should be outgoing, and
// it's parent too.
assert!(outgoing.contains(&"bookmarkEEEE".into()));
assert!(outgoing.contains(&"folderCCCCCC".into()));
Ok(())
}
/*
* localID = None/Null, but mergedGuid was something already locally in the
* tree -- this lead to an uptick of guid collision issues in `apply_remote_items`
* below is an example of a 'user' going into this state and the new code fixing it
*/
#[test]
fn test_handle_unique_guid_violation() -> Result<()> {
let api = new_mem_api();
let db = api.get_sync_connection().unwrap();
let conn = db.lock();
conn.execute_batch(
r#"
INSERT INTO moz_places(url, guid, title, frecency)
VALUES
"#,
)?;
// Insert a local row in moz_bookmarks with guid="collisionGUI"
// so we already have that GUID in the table.
conn.execute_batch(&format!(
r#"
INSERT INTO moz_bookmarks(guid, parent, fk, position, type)
VALUES (
'collisionGUI',
(SELECT id FROM moz_bookmarks WHERE guid = '{menu}'),
(SELECT id FROM moz_places WHERE guid = 'testPlaceGuidAAAA'),
0,
1 -- type=1 => bookmark
);
"#,
menu = BookmarkRootGuid::Menu.as_guid(),
))?;
// Insert a row into itemsToApply that will cause an insert
// with the same guid="collisionGUI".
// localId is NULL, so the engine sees it as a "new" local item,
// and remoteId could be any integer. We set newKind=1 => "bookmark."
conn.execute(
r#"
INSERT INTO itemsToApply(
mergedGuid,
localId,
remoteId,
remoteGuid,
newKind,
newLevel,
newTitle,
newPlaceId,
oldPlaceId,
localDateAdded,
remoteDateAdded,
lastModified
)
VALUES (
?1, -- mergedGuid
NULL, -- localId => so it doesn't unify
999, -- remoteId => arbitrary
?1, -- remoteGuid
1, -- newKind=1 => bookmark
0, -- level
'New Title', -- newTitle
1, -- newPlaceId
NULL, -- oldPlaceId
1000, -- localDateAdded
2000, -- remoteDateAdded
2000 -- lastModified
)
"#,
[&"collisionGUI"],
)?;
// Call apply_remote_items directly.
// This tries "INSERT INTO moz_bookmarks(guid='collisionGUI')"
// and should NOT fail with a unique constraint.
let scope = conn.begin_interrupt_scope()?;
apply_remote_items(&conn, &scope, Timestamp(999))?;
// Assert the tree still looks valid after applying
assert_local_json_tree(
&conn,
&BookmarkRootGuid::Menu.as_guid(),
json!({
"guid": &BookmarkRootGuid::Menu.as_guid(),
// should only be one child
"children": [{
"guid": "collisionGUI",
"title": "New Title", // title was updated from remote
}],
}),
);
Ok(())
}
}