Source code

Revision control

Copy as Markdown

Other Tools

<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 9.2.1" type="baseline" client="gradle" dependencies="false" name="AGP (9.2.1)" variant="all" version="9.2.1">
<issue
id="UseFragmentContent"
message="Prefer content {} instead of manually constructing a ComposeView in onCreateView()."
errorLine1=" return ComposeView(requireContext()).apply {"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/focus/settings/BaseComposeFragment.kt"
line="75"
column="16"/>
</issue>
<issue
id="UseFragmentContent"
message="Prefer content {} instead of manually constructing a ComposeView in onCreateView()."
errorLine1=" return ComposeView(requireContext()).apply {"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/focus/biometrics/BiometricAuthenticationFragment.kt"
line="43"
column="16"/>
</issue>
<issue
id="UseFragmentContent"
message="Prefer content {} instead of manually constructing a ComposeView in onCreateView()."
errorLine1=" return ComposeView(requireContext()).apply {"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/focus/fragment/onboarding/OnboardingFirstFragment.kt"
line="65"
column="16"/>
</issue>
<issue
id="UseFragmentContent"
message="Prefer content {} instead of manually constructing a ComposeView in onCreateView()."
errorLine1=" return ComposeView(requireContext()).apply {"
errorLine2=" ~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/focus/fragment/onboarding/OnboardingSecondFragment.kt"
line="59"
column="16"/>
</issue>
<issue
id="AppBundleLocaleChanges"
message="Found dynamic locale changes, but did not find corresponding Play Core library calls for downloading languages and splitting by language is not disabled in the `bundle` configuration"
errorLine1=" configuration.setLocale(locale)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/focus/locale/screen/LanguageMiddleware.kt"
line="84"
column="13"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/fragment_crash_reporter.xml"
line="70"
column="6"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/fragment_exceptions_domains.xml"
line="30"
column="6"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/fragment_search_suggestions.xml"
line="108"
column="10"/>
</issue>
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width=&quot;640dp&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/res/drawable-land-night/home_background.xml"
line="8"
column="20"/>
</issue>
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width=&quot;640dp&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/res/drawable-land/home_background.xml"
line="8"
column="20"/>
</issue>
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width=&quot;360dp&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/res/drawable-night/home_background.xml"
line="8"
column="20"/>
</issue>
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width=&quot;360dp&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/res/drawable/home_background.xml"
line="8"
column="20"/>
</issue>
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width=&quot;300dp&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/res/drawable/ic_error_session_crashed.xml"
line="7"
column="20"/>
</issue>
<issue
id="VectorRaster"
message="Limit vector icons sizes to 200×200 to keep icon drawing fast; see https://developer.android.com/studio/write/vector-asset-studio#when for more"
errorLine1=" android:width=&quot;384dp&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/res/drawable/wordmark2.xml"
line="7"
column="20"/>
</issue>
<issue
id="DataExtractionRules"
message="The attribute `android:allowBackup` is deprecated from Android 12 and higher and may be removed in future versions. Consider adding the attribute `android:dataExtractionRules` specifying an `@xml` resource which configures cloud backups and device transfers on Android 12 and higher."
errorLine1=" android:allowBackup=&quot;false&quot;"
errorLine2=" ~~~~~">
<location
file="src/main/AndroidManifest.xml"
line="65"
column="30"/>
</issue>
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" &lt;androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/dialog_add_to_homescreen2.xml"
line="73"
column="6"/>
</issue>
<issue
id="MozMultipleConstraintLayouts"
message="Flatten the view hierarchy by using one `ConstraintLayout`, if possible. If the alternative is several nested `ViewGroup`, it may not help performance and this may be worth suppressing."
errorLine1=" &lt;androidx.constraintlayout.widget.ConstraintLayout"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_search_suggestions.xml"
line="89"
column="6"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/focus/autocomplete/AutocompleteListFragment.kt"
line="196"
column="13"/>
</issue>
<issue
id="NotifyDataSetChanged"
message="It will always be more efficient to use more specific change events if you can. Rely on `notifyDataSetChanged` as a last resort."
errorLine1=" notifyDataSetChanged()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/org/mozilla/focus/exceptions/ExceptionsListFragment.kt"
line="209"
column="21"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/settings_background` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;@color/settings_background&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/activity_main.xml"
line="9"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/settings_background` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;@color/settings_background&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_autocomplete_add_domain.xml"
line="10"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/settings_background` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;@color/settings_background&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_autocomplete_customdomains.xml"
line="10"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/photonGrey10` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;@color/photonGrey10&quot;>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_crash_reporter.xml"
line="12"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/settings_background` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;@color/settings_background&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_exceptions_domains.xml"
line="10"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/settings_background` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;@color/settings_background&quot; />"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/fragment_settings.xml"
line="11"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;?selectableItemBackground&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/item_add_custom_domain.xml"
line="14"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:attr/selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;?android:attr/selectableItemBackground&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/search_engine_checkbox_button.xml"
line="12"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `?android:attr/selectableItemBackground` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;?android:attr/selectableItemBackground&quot;"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/search_engine_radio_button.xml"
line="10"
column="5"/>
</issue>
<issue
id="Overdraw"
message="Possible overdraw: Root element paints background `@color/settings_background` with a theme that also paints a background (inferred theme is `@style/Theme.App.Starting`)"
errorLine1=" android:background=&quot;@color/settings_background&quot;/>"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/res/layout/toolbar.xml"
line="9"
column="5"/>
</issue>
<issue
id="MonochromeLauncherIcon"
message="The application adaptive icon is missing a monochrome tag"
errorLine1="&lt;adaptive-icon xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;>"
errorLine2="^">
<location
file="src/debug/res/mipmap-anydpi/ic_launcher.xml"
line="6"
column="1"/>
</issue>
<issue
id="MonochromeLauncherIcon"
message="The application adaptive icon is missing a monochrome tag"
errorLine1="&lt;adaptive-icon xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;>"
errorLine2="^">
<location
file="src/main/res/mipmap-anydpi/ic_launcher.xml"
line="6"
column="1"/>
</issue>
<issue
id="IconMissingDensityFolder"
message="Missing density variation folders in `src/main/res`: drawable-mdpi, drawable-xhdpi, drawable-xxhdpi">
<location
file="src/main/res"/>
</issue>
</issues>