Source code

Revision control

Other Tools

Getting reviews
===============
Thorough code reviews are one of Mozilla's ways of ensuring code quality.
Every patch must be reviewed by the module owner of the code, or one of their designated peers.
To request a review, you will need to specify a review group (starts with #). If there is not, you should select one or more usernames either when you submit the patch, or afterward in the UI.
If you have a mentor, the mentor can usually either also review or find a suitable reviewer on your behalf.
For example, the syntax to request review from a group should be:
.. code-block::
Bug xxxx - explain what you are doing and why r?#group-name
or
Bug xxxx - explain what you are doing and why r?developer-nickname
Getting attention: If a reviewer doesn't respond within a week, or so of the review request:
* Contact the reviewer directly (either via e-mail or on Matrix).
* Join developers on `Mozilla's Matrix server <https://chat.mozilla.org>`_, and ask if anyone knows why a review may be delayed. Please link to the bug too.
* If the review is still not addressed, mail the reviewer directly, asking if/when they'll have time to review the patch, or might otherwise be able to review it.
Review groups
-------------
.. list-table::
:header-rows: 1
* - Name
- Owns
- Members
* - #anti-tracking or #anti-tracking-reviewers
* - #build or #firefox-build-system-reviewers
- The configure & build system
* - #dom-workers-and-storage-reviewers
- DOM Workers & Storage
* - #devtools-reviewers
- Firefox DevTools
* - #fluent-reviewers
- Changes to Fluent (FTL) files (translation).
* - #firefox-source-docs-reviewers
- Documentation files and its build
* - #firefox-ux-team
- User experience (UX)
* - #firefox-svg-reviewers
- SVG-related changes
* - #geckoview-reviewers
- Changes to GeckoView
* - #gfx-reviewers
- Changes to Graphics code
* - #intermittent-reviewers
- Test manifest changes
* - #layout-reviewers
- Layout changes.
* - #linter-reviewers
- tools/lint/*
* - #mozbase
- Changes to Mozbase
* - #mozbase-rust
- Changes to Mozbase in Rust
* - #nss-reviewers
- Changes to Network Security Services (NSS)
* - #perftest-reviewers
- Perf Tests
* - #permissions or #permissions-reviewers
* - #platform-i18n-reviewers
- Platform Internationalization
* - #preferences-reviewers
- Firefox for Desktop Preferences (Options) user interface
* - #remote-debugging-reviewers
- Remote Debugging UI & tools
* - #static-analysis-reviewers
- Changes related to Static Analysis
* - #style or #firefox-style-system-reviewers
- Firefox style system (servo, layout/style).
* - #webcompat-reviewers
- System addons maintained by the Web Compatibility team
* - #webdriver-reviewers
- Marionette and geckodriver (including MozBase Rust), and Remote Protocol with WebDriver BiDi, and CDP.
* - #webidl
- Changes related to WebIDL
* - #xpcom-reviewers
- Changes related to XPCOM
To create a new group, fill a `new bug in Conduit::Administration <https://bugzilla.mozilla.org/enter_bug.cgi?product=Conduit&component=Administration>`__.